kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Support XMemcached V2.x

This commit is contained in:
IluckySi 2017-10-17 09:31:37 +08:00
parent 13cf324789
commit a6cd991c13
3 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/main/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedConstructorWithComplexArgInterceptor.java
View File

@ -34,13 +34,13 @@ public class XMemcachedConstructorWithComplexArgInterceptor implements InstanceC
Map<InetSocketAddress, InetSocketAddress> inetSocketAddressMap = (Map<InetSocketAddress, InetSocketAddress>)allArguments[6];
StringBuilder master = new StringBuilder();
for (Entry<InetSocketAddress, InetSocketAddress> entry : inetSocketAddressMap.entrySet()) {
if (master.length() <= 0) {
if (master.length() == 0) {
master = append(master,entry.getKey());
}
memcachConnInfo = append(memcachConnInfo, entry.getValue());
}
memcachConnInfo = master.append(memcachConnInfo);
int l = memcachConnInfo.length();
Integer l = memcachConnInfo.length();
if (l > 1) {
memcachConnInfo = new StringBuilder(memcachConnInfo.substring(0, l - 1));
}

4
apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/main/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedMethodInterceptor.java
View File

@ -37,8 +37,8 @@ public class XMemcachedMethodInterceptor implements InstanceMethodsAroundInterce
Class<?>[] argumentsTypes, MethodInterceptResult result) throws Throwable {
String peer = String.valueOf(objInst.getSkyWalkingDynamicField());
AbstractSpan span = ContextManager.createExitSpan(XMEMCACHED + method.getName(), peer);
span.setComponent(ComponentsDefine.MEMCACHE);
Tags.DB_TYPE.set(span, ComponentsDefine.MEMCACHE.getName());
span.setComponent(ComponentsDefine.MEMCACHED);
Tags.DB_TYPE.set(span, ComponentsDefine.MEMCACHED.getName());
SpanLayer.asDB(span);
Tags.DB_STATEMENT.set(span, method.getName() + " " + allArguments[0]);
}

18
apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/test/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedMethodInterceptorTest.java
View File

@ -121,21 +121,11 @@ public class XMemcachedMethodInterceptorTest {
assertThat(SpanHelper.getLayer(span), is(SpanLayer.DB));
}
private Method getMockSetMethod() {
try {
return XMemcachedClient.class.getMethod("set", String.class, int.class, Object.class);
} catch (NoSuchMethodException e) {
e.printStackTrace();
return null;
}
private Method getMockSetMethod() throws Exception {
return XMemcachedClient.class.getMethod("set", String.class, int.class, Object.class);
}
private Method getMockGetMethod() {
try {
return XMemcachedClient.class.getMethod("get", String.class);
} catch (NoSuchMethodException e) {
e.printStackTrace();
return null;
}
private Method getMockGetMethod() throws Exception {
return XMemcachedClient.class.getMethod("get", String.class);
}
}