diff --git a/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/main/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedConstructorWithComplexArgInterceptor.java b/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/main/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedConstructorWithComplexArgInterceptor.java index 6649df283..6a4409f97 100644 --- a/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/main/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedConstructorWithComplexArgInterceptor.java +++ b/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/main/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedConstructorWithComplexArgInterceptor.java @@ -34,13 +34,13 @@ public class XMemcachedConstructorWithComplexArgInterceptor implements InstanceC Map inetSocketAddressMap = (Map)allArguments[6]; StringBuilder master = new StringBuilder(); for (Entry entry : inetSocketAddressMap.entrySet()) { - if (master.length() <= 0) { + if (master.length() == 0) { master = append(master,entry.getKey()); } memcachConnInfo = append(memcachConnInfo, entry.getValue()); } memcachConnInfo = master.append(memcachConnInfo); - int l = memcachConnInfo.length(); + Integer l = memcachConnInfo.length(); if (l > 1) { memcachConnInfo = new StringBuilder(memcachConnInfo.substring(0, l - 1)); } diff --git a/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/main/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedMethodInterceptor.java b/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/main/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedMethodInterceptor.java index c3d30d8da..0b34205c1 100644 --- a/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/main/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedMethodInterceptor.java +++ b/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/main/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedMethodInterceptor.java @@ -37,8 +37,8 @@ public class XMemcachedMethodInterceptor implements InstanceMethodsAroundInterce Class[] argumentsTypes, MethodInterceptResult result) throws Throwable { String peer = String.valueOf(objInst.getSkyWalkingDynamicField()); AbstractSpan span = ContextManager.createExitSpan(XMEMCACHED + method.getName(), peer); - span.setComponent(ComponentsDefine.MEMCACHE); - Tags.DB_TYPE.set(span, ComponentsDefine.MEMCACHE.getName()); + span.setComponent(ComponentsDefine.MEMCACHED); + Tags.DB_TYPE.set(span, ComponentsDefine.MEMCACHED.getName()); SpanLayer.asDB(span); Tags.DB_STATEMENT.set(span, method.getName() + " " + allArguments[0]); } diff --git a/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/test/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedMethodInterceptorTest.java b/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/test/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedMethodInterceptorTest.java index 4a3ba6f26..5e59234b2 100644 --- a/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/test/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedMethodInterceptorTest.java +++ b/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/test/java/org/skywalking/apm/plugin/xmemcached/v2/XMemcachedMethodInterceptorTest.java @@ -121,21 +121,11 @@ public class XMemcachedMethodInterceptorTest { assertThat(SpanHelper.getLayer(span), is(SpanLayer.DB)); } - private Method getMockSetMethod() { - try { - return XMemcachedClient.class.getMethod("set", String.class, int.class, Object.class); - } catch (NoSuchMethodException e) { - e.printStackTrace(); - return null; - } + private Method getMockSetMethod() throws Exception { + return XMemcachedClient.class.getMethod("set", String.class, int.class, Object.class); } - private Method getMockGetMethod() { - try { - return XMemcachedClient.class.getMethod("get", String.class); - } catch (NoSuchMethodException e) { - e.printStackTrace(); - return null; - } + private Method getMockGetMethod() throws Exception { + return XMemcachedClient.class.getMethod("get", String.class); } } \ No newline at end of file