From fed3df305ef2ba227cead177091c4a084e99aeef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=90=B4=E6=99=9F=20Wu=20Sheng?= Date: Sat, 19 Mar 2022 09:38:15 +0800 Subject: [PATCH] Fix comments. (#8708) --- CHANGES.md | 4 ++-- .../skywalking/oap/server/core/storage/annotation/Column.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 29e605beb2..460fdd064f 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -125,8 +125,8 @@ Release Notes. * Add `Column.shardingKeyIdx` for column definition for BanyanDB. ``` -Sharding key is used to group time series data per metric of one entity in one place (same sharding or same -column for column-oriented database). +Sharding key is used to group time series data per metric of one entity in one place (same sharding and/or same +row for column-oriented database). For example, ServiceA's traffic gauge, service call per minute, includes following timestamp values, then it should be sharded by service ID [ServiceA(encoded ID): 01-28 18:30 values-1, 01-28 18:31 values-2, 01-28 18:32 values-3, 01-28 18:32 values-4] diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java index 17ba2e0422..077fdfe6dd 100644 --- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java +++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java @@ -102,8 +102,8 @@ public @interface Column { AnalyzerType analyzer() default AnalyzerType.OAP_ANALYZER; /** - * Sharding key is used to group time series data per metric of one entity in one place (same sharding or same - * column for column-oriented database). + * Sharding key is used to group time series data per metric of one entity in one place (same sharding and/or same + * row for column-oriented database). * For example, * ServiceA's traffic gauge, service call per minute, includes following timestamp values, then it should be sharded * by service ID