kazusa
/
skywalking
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix bug for Kafka report plugin (#7016)

This commit is contained in:
Darcy 2021-05-26 16:53:28 +08:00 committed by GitHub
parent e9b9be4ab5
commit f6a0efdecd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
apm-sniffer/optional-reporter-plugins/kafka-reporter-plugin/src/main/java/org/apache/skywalking/apm/agent/core/kafka/KafkaProducerManager.java
View File

@ -120,6 +120,7 @@ public class KafkaProducerManager implements BootService, Runnable {
.collect(Collectors.toSet());
if (!topics.isEmpty()) {
LOGGER.warn("kafka topics {} is not exist, connect to kafka cluster abort", topics);
closeAdminClient(adminClient);
return;
}
@ -127,6 +128,7 @@ public class KafkaProducerManager implements BootService, Runnable {
producer = new KafkaProducer<>(properties, new StringSerializer(), new BytesSerializer());
} catch (Exception e) {
LOGGER.error(e, "connect to kafka cluster '{}' failed", KafkaReporterPluginConfig.Plugin.Kafka.BOOTSTRAP_SERVERS);
closeAdminClient(adminClient);
return;
}
//notify listeners to send data if no exception been throw
@ -140,6 +142,16 @@ public class KafkaProducerManager implements BootService, Runnable {
}
}
private void closeAdminClient(AdminClient adminClient) {
if (adminClient != null) {
try {
adminClient.close();
} catch (Exception e) {
LOGGER.error("close kafka admin client failed", e);
}
}
}
/**
* Get the KafkaProducer instance to send data to Kafka broker.
*/
@ -162,4 +174,4 @@ public class KafkaProducerManager implements BootService, Runnable {
producer.flush();
producer.close();
}
}
}