kazusa
/
skywalking
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix typo: guideline and code document (#4248)

This commit is contained in:
John Niang 2020-01-16 19:38:03 +08:00 committed by 吴晟 Wu Sheng
parent 8e5e35f096
commit 738e4975cb
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/en/guides/How-to-build.md
View File

@ -133,6 +133,6 @@ Refer to [Build docker image](../../../docker) for more details.
</dependency>
```
5. Run `./mvnw compile -Dmaven.test.skip=true`
6. Run `maven update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the complie)
6. Run `maven update`. Must remove the clean projects item before maven update(This will be clear the proto conversion Java file generated by the compiling)
7. Run `./mvnw compile` compile collector-remote-grpc-provider and apm-protocol
8. Refresh project

2
oap-server/server-library/library-module/src/main/java/org/apache/skywalking/oap/server/library/module/ModuleProvider.java
View File

@ -76,7 +76,7 @@ public abstract class ModuleProvider implements ModuleServiceHolder {
public abstract String[] requiredModules();
/**
* Register a implementation for the service of this moduleDefine provider.
* Register an implementation for the service of this moduleDefine provider.
*/
@Override public final void registerServiceImplementation(Class<? extends Service> serviceType,
Service service) throws ServiceNotProvidedException {