kazusa
/
skywalking
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary `onCompleted` on gRPC error (#9027)

This commit is contained in:
kezhenxu94 2022-05-10 19:37:03 +08:00 committed by GitHub
parent 59c63d90e8
commit 7344714ee9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/en/changes/changes.md
View File

@ -47,6 +47,7 @@
* Fix the pod match error when the service has multiple selector in kubernetes environment.
* VM monitoring adapts the 0.50.0 of the `opentelemetry-collector`.
* Add Envoy internal cost metrics.
* Remove unnecessary `onCompleted` on gRPC `onError` callback.
#### UI

3
oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/grpc/AlarmMockReceiver.java
View File

@ -55,7 +55,6 @@ public class AlarmMockReceiver {
if (log.isDebugEnabled()) {
log.debug("received alarm message error.");
}
responseObserver.onCompleted();
}
@Override
@ -69,4 +68,4 @@ public class AlarmMockReceiver {
};
}
}
}
}

1
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/AccessLogServiceGRPCHandler.java
View File

@ -171,7 +171,6 @@ public class AccessLogServiceGRPCHandler extends AccessLogServiceGrpc.AccessLogS
@Override
public void onError(Throwable throwable) {
LOGGER.error("Error in receiving access log from envoy", throwable);
responseObserver.onCompleted();
}
@Override

1
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/MetricServiceGRPCHandler.java
View File

@ -130,7 +130,6 @@ public class MetricServiceGRPCHandler extends MetricsServiceGrpc.MetricsServiceI
@Override
public void onError(Throwable throwable) {
log.error("Error in receiving metrics from envoy", throwable);
responseObserver.onCompleted();
}
@Override

1
oap-server/server-receiver-plugin/skywalking-browser-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/browser/provider/handler/grpc/BrowserPerfServiceHandler.java
View File

@ -131,7 +131,6 @@ public class BrowserPerfServiceHandler extends BrowserPerfServiceGrpc.BrowserPer
@Override
public void onError(final Throwable throwable) {
log.error(throwable.getMessage(), throwable);
responseObserver.onCompleted();
}
@Override

1
oap-server/server-receiver-plugin/skywalking-ebpf-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/ebpf/provider/handler/EBPFProfilingServiceHandler.java
View File

@ -168,7 +168,6 @@ public class EBPFProfilingServiceHandler extends EBPFProfilingServiceGrpc.EBPFPr
@Override
public void onError(Throwable throwable) {
log.error("Error in receiving ebpf profiling data", throwable);
responseObserver.onCompleted();
}
@Override

1
oap-server/server-receiver-plugin/skywalking-event-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/event/grpc/EventGrpcServiceHandler.java
View File

@ -94,7 +94,6 @@ public class EventGrpcServiceHandler extends EventServiceGrpc.EventServiceImplBa
@Override
public void onError(Throwable throwable) {
log.error(throwable.getMessage(), throwable);
responseObserver.onCompleted();
}
@Override

1
oap-server/server-receiver-plugin/skywalking-log-recevier-plugin/src/main/java/org/apache/skywalking/oap/server/recevier/log/provider/handler/grpc/LogReportServiceGrpcHandler.java
View File

@ -99,7 +99,6 @@ public class LogReportServiceGrpcHandler extends LogReportServiceGrpc.LogReportS
@Override
public void onError(final Throwable throwable) {
log.error(throwable.getMessage(), throwable);
responseObserver.onCompleted();
}
@Override

1
oap-server/server-receiver-plugin/skywalking-mesh-receiver-plugin/src/main/java/org/apache/skywalking/aop/server/receiver/mesh/MeshGRPCHandler.java
View File

@ -48,7 +48,6 @@ public class MeshGRPCHandler extends ServiceMeshMetricServiceGrpc.ServiceMeshMet
@Override
public void onError(Throwable throwable) {
LOGGER.error(throwable.getMessage(), throwable);
responseObserver.onCompleted();
}
@Override

2
oap-server/server-receiver-plugin/skywalking-meter-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/meter/provider/handler/MeterServiceHandler.java
View File

@ -77,7 +77,6 @@ public class MeterServiceHandler extends MeterReportServiceGrpc.MeterReportServi
public void onError(Throwable throwable) {
processor.process();
log.error(throwable.getMessage(), throwable);
responseObserver.onCompleted();
}
@Override
@ -107,7 +106,6 @@ public class MeterServiceHandler extends MeterReportServiceGrpc.MeterReportServi
@Override
public void onError(Throwable throwable) {
log.error(throwable.getMessage(), throwable);
responseObserver.onCompleted();
}
@Override

1
oap-server/server-receiver-plugin/skywalking-profile-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/profile/provider/handler/ProfileTaskServiceHandler.java
View File

@ -112,7 +112,6 @@ public class ProfileTaskServiceHandler extends ProfileTaskGrpc.ProfileTaskImplBa
@Override
public void onError(Throwable throwable) {
LOGGER.error(throwable.getMessage(), throwable);
responseObserver.onCompleted();
}
@Override

1
oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/handler/v8/grpc/TraceSegmentReportServiceHandler.java
View File

@ -81,7 +81,6 @@ public class TraceSegmentReportServiceHandler extends TraceSegmentReportServiceG
@Override
public void onError(Throwable throwable) {
log.error(throwable.getMessage(), throwable);
responseObserver.onCompleted();
}
@Override