kazusa
/
skywalking
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Fix NPE if no TopN rules (#13320)

This commit is contained in:
Wan Kai 2025-06-17 16:00:01 +08:00 committed by GitHub
parent 39508f81c8
commit 57746c24d3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBConfigLoader.java
View File

@ -38,15 +38,13 @@ import static org.apache.skywalking.oap.server.library.util.YamlConfigLoaderUtil
@Slf4j
public class BanyanDBConfigLoader {
private final ModuleProvider moduleProvider;
private BanyanDBStorageConfig config;
private final BanyanDBStorageConfig config;
private final Yaml yaml;
private final Yaml topNYaml;
public BanyanDBConfigLoader(final ModuleProvider moduleProvider) {
this.moduleProvider = moduleProvider;
this.config = new BanyanDBStorageConfig();
this.yaml = new Yaml();
this.topNYaml = new Yaml();
}
public BanyanDBStorageConfig loadConfig() throws ModuleStartException {
@ -199,11 +197,14 @@ public class BanyanDBConfigLoader {
} catch (FileNotFoundException e) {
throw new ModuleStartException("Cannot find the BanyanDB topN configuration file [bydb-topn.yml].", e);
}
Map<String, List<Map<String, ?>>> configMap = yaml.loadAs(applicationReader, Map.class);
Map<String, List<Map<String, ?>>> configMap = new Yaml().loadAs(applicationReader, Map.class);
if (configMap == null) {
return;
}
List<Map<String, ?>> topNConfig = configMap.get("TopN-Rules");
if (topNConfig == null) {
return;
}
for (Map<String, ?> rule : topNConfig) {
TopN topN = new TopN();
var name = rule.get("name");