kazusa
/
skywalking
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Storage elasticsearch health check (#5099)

This commit is contained in:
Gao Hongtao 2020-07-19 23:37:13 +08:00 committed by GitHub
parent 977062bafb
commit 3fdfdf3b83
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
13 changed files with 368 additions and 82 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/StringUtil.java
View File

@ -18,6 +18,8 @@
package org.apache.skywalking.apm.util;
import java.util.function.Consumer;
public final class StringUtil {
public static boolean isEmpty(String str) {
return str == null || str.length() == 0;
@ -27,6 +29,12 @@ public final class StringUtil {
return !isEmpty(str);
}
public static void setIfPresent(String value, Consumer<String> setter) {
if (isNotEmpty(value)) {
setter.accept(value);
}
}
public static String join(final char delimiter, final String... strings) {
if (strings.length == 0) {
return null;

6
oap-server/server-library/library-client/pom.xml
View File

@ -29,6 +29,12 @@
<packaging>jar</packaging>
<dependencies>
<dependency>
<groupId>org.apache.skywalking</groupId>
<artifactId>library-util</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-core</artifactId>

103
oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java
View File

@ -37,7 +37,9 @@ import java.util.HashMap;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.concurrent.locks.ReentrantLock;
import javax.net.ssl.SSLContext;
import lombok.RequiredArgsConstructor;
import lombok.Setter;
import lombok.extern.slf4j.Slf4j;
import org.apache.http.HttpEntity;
@ -58,8 +60,11 @@ import org.apache.http.ssl.SSLContextBuilder;
import org.apache.http.ssl.SSLContexts;
import org.apache.skywalking.apm.util.StringUtil;
import org.apache.skywalking.oap.server.library.client.Client;
import org.apache.skywalking.oap.server.library.client.healthcheck.DelegatedHealthChecker;
import org.apache.skywalking.oap.server.library.client.healthcheck.HealthCheckable;
import org.apache.skywalking.oap.server.library.client.request.InsertRequest;
import org.apache.skywalking.oap.server.library.client.request.UpdateRequest;
import org.apache.skywalking.oap.server.library.util.HealthChecker;
import org.elasticsearch.action.admin.indices.create.CreateIndexRequest;
import org.elasticsearch.action.admin.indices.create.CreateIndexResponse;
import org.elasticsearch.action.admin.indices.delete.DeleteIndexRequest;
@ -90,7 +95,8 @@ import org.elasticsearch.search.builder.SearchSourceBuilder;
* ElasticSearchClient connects to the ES server by using ES client APIs.
*/
@Slf4j
public class ElasticSearchClient implements Client {
@RequiredArgsConstructor
public class ElasticSearchClient implements Client, HealthCheckable {
public static final String TYPE = "type";
protected final String clusterNodes;
protected final String protocol;
@ -103,6 +109,8 @@ public class ElasticSearchClient implements Client {
private volatile String password;
private final List<IndexNameConverter> indexNameConverters;
protected volatile RestHighLevelClient client;
protected DelegatedHealthChecker healthChecker = new DelegatedHealthChecker();
protected final ReentrantLock connectLock = new ReentrantLock();
public ElasticSearchClient(String clusterNodes,
String protocol,
@ -122,6 +130,8 @@ public class ElasticSearchClient implements Client {
@Override
public void connect() throws IOException, KeyStoreException, NoSuchAlgorithmException, KeyManagementException, CertificateException {
connectLock.lock();
try {
List<HttpHost> hosts = parseClusterNodes(protocol, clusterNodes);
if (client != null) {
try {
@ -132,6 +142,9 @@ public class ElasticSearchClient implements Client {
}
client = createClient(hosts);
client.ping();
} finally {
connectLock.unlock();
}
}
protected RestHighLevelClient createClient(
@ -208,10 +221,23 @@ public class ElasticSearchClient implements Client {
public List<String> retrievalIndexByAliases(String aliases) throws IOException {
aliases = formatIndexName(aliases);
Response response = client.getLowLevelClient().performRequest(HttpGet.METHOD_NAME, "/_alias/" + aliases);
Response response;
try {
response = client.getLowLevelClient().performRequest(HttpGet.METHOD_NAME, "/_alias/" + aliases);
healthChecker.health();
} catch (Throwable t) {
healthChecker.unHealth(t);
throw t;
}
if (HttpStatus.SC_OK == response.getStatusLine().getStatusCode()) {
Gson gson = new Gson();
InputStreamReader reader = new InputStreamReader(response.getEntity().getContent());
InputStreamReader reader;
try {
reader = new InputStreamReader(response.getEntity().getContent());
} catch (Throwable t) {
healthChecker.unHealth(t);
throw t;
}
JsonObject responseJson = gson.fromJson(reader, JsonObject.class);
log.debug("retrieval indexes by aliases {}, response is {}", aliases, responseJson);
return new ArrayList<>(responseJson.keySet());
@ -310,13 +336,44 @@ public class ElasticSearchClient implements Client {
SearchRequest searchRequest = new SearchRequest(indexName);
searchRequest.types(TYPE);
searchRequest.source(searchSourceBuilder);
return client.search(searchRequest);
try {
SearchResponse response = client.search(searchRequest);
healthChecker.health();
return response;
} catch (Throwable t) {
healthChecker.unHealth(t);
handleIOPoolStopped(t);
throw t;
}
}
protected void handleIOPoolStopped(Throwable t) throws IOException {
if (!(t instanceof IllegalStateException)) {
return;
}
IllegalStateException ise = (IllegalStateException) t;
// Fixed the issue described in https://github.com/elastic/elasticsearch/issues/39946
if (ise.getMessage().contains("I/O reactor status: STOPPED") &&
connectLock.tryLock()) {
try {
connect();
} catch (KeyStoreException | NoSuchAlgorithmException | KeyManagementException | CertificateException e) {
throw new IllegalStateException("Can't reconnect to Elasticsearch", e);
}
}
}
public GetResponse get(String indexName, String id) throws IOException {
indexName = formatIndexName(indexName);
GetRequest request = new GetRequest(indexName, TYPE, id);
return client.get(request);
try {
GetResponse response = client.get(request);
healthChecker.health();
return response;
} catch (Throwable t) {
healthChecker.unHealth(t);
throw t;
}
}
public SearchResponse ids(String indexName, String[] ids) throws IOException {
@ -325,28 +382,39 @@ public class ElasticSearchClient implements Client {
SearchRequest searchRequest = new SearchRequest(indexName);
searchRequest.types(TYPE);
searchRequest.source().query(QueryBuilders.idsQuery().addIds(ids)).size(ids.length);
return client.search(searchRequest);
try {
SearchResponse response = client.search(searchRequest);
healthChecker.health();
return response;
} catch (Throwable t) {
healthChecker.unHealth(t);
throw t;
}
}
public void forceInsert(String indexName, String id, XContentBuilder source) throws IOException {
IndexRequest request = (IndexRequest) prepareInsert(indexName, id, source);
request.setRefreshPolicy(WriteRequest.RefreshPolicy.IMMEDIATE);
try {
client.index(request);
healthChecker.health();
} catch (Throwable t) {
healthChecker.unHealth(t);
throw t;
}
public void forceUpdate(String indexName, String id, XContentBuilder source, long version) throws IOException {
org.elasticsearch.action.update.UpdateRequest request = (org.elasticsearch.action.update.UpdateRequest) prepareUpdate(
indexName, id, source);
request.version(version);
request.setRefreshPolicy(WriteRequest.RefreshPolicy.IMMEDIATE);
client.update(request);
}
public void forceUpdate(String indexName, String id, XContentBuilder source) throws IOException {
org.elasticsearch.action.update.UpdateRequest request = (org.elasticsearch.action.update.UpdateRequest) prepareUpdate(
indexName, id, source);
request.setRefreshPolicy(WriteRequest.RefreshPolicy.IMMEDIATE);
try {
client.update(request);
healthChecker.health();
} catch (Throwable t) {
healthChecker.unHealth(t);
throw t;
}
}
public InsertRequest prepareInsert(String indexName, String id, XContentBuilder source) {
@ -379,8 +447,9 @@ public class ElasticSearchClient implements Client {
int size = request.requests().size();
BulkResponse responses = client.bulk(request);
log.info("Synchronous bulk took time: {} millis, size: {}", responses.getTook().getMillis(), size);
} catch (IOException e) {
log.error(e.getMessage(), e);
healthChecker.health();
} catch (Throwable t) {
healthChecker.unHealth(t);
}
}
@ -431,4 +500,8 @@ public class ElasticSearchClient implements Client {
}
return indexName;
}
@Override public void registerChecker(HealthChecker healthChecker) {
this.healthChecker.register(healthChecker);
}
}

39
oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/healthcheck/DelegatedHealthChecker.java Normal file
View File

@ -0,0 +1,39 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
package org.apache.skywalking.oap.server.library.client.healthcheck;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicReference;
import org.apache.skywalking.oap.server.library.util.HealthChecker;
public class DelegatedHealthChecker implements HealthChecker {
private final AtomicReference<HealthChecker> delegated = new AtomicReference<>();
@Override public void health() {
Optional.ofNullable(delegated.get()).ifPresent(HealthChecker::health);
}
@Override public void unHealth(Throwable t) {
Optional.ofNullable(delegated.get()).ifPresent(d -> d.unHealth(t));
}
public void register(HealthChecker healthChecker) {
delegated.set(healthChecker);
}
}

34
oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/healthcheck/HealthCheckable.java Normal file
View File

@ -0,0 +1,34 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
package org.apache.skywalking.oap.server.library.client.healthcheck;
import org.apache.skywalking.oap.server.library.util.HealthChecker;
/**
* HealthCheckable indicate the client has the capacity of health check and need to register healthChecker.
*/
public interface HealthCheckable {
/**
* Register health checker.
*
* @param healthChecker HealthChecker to be registered.
*/
void registerChecker(HealthChecker healthChecker);
}

34
oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/jdbc/hikaricp/JDBCHikariCPClient.java
View File

@ -26,37 +26,27 @@ import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.Properties;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
import java.util.function.Consumer;
import org.apache.skywalking.oap.server.library.client.Client;
import org.apache.skywalking.oap.server.library.client.healthcheck.DelegatedHealthChecker;
import org.apache.skywalking.oap.server.library.client.healthcheck.HealthCheckable;
import org.apache.skywalking.oap.server.library.client.jdbc.JDBCClientException;
import org.apache.skywalking.oap.server.library.util.HealthChecker;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
* JDBC Client uses HikariCP connection management lib to execute SQL.
*/
public class JDBCHikariCPClient implements Client {
public class JDBCHikariCPClient implements Client, HealthCheckable {
private static final Logger logger = LoggerFactory.getLogger(JDBCHikariCPClient.class);
private final HikariConfig hikariConfig;
private final DelegatedHealthChecker healthChecker;
private HikariDataSource dataSource;
private HikariConfig hikariConfig;
public JDBCHikariCPClient(Properties properties) {
hikariConfig = new HikariConfig(properties);
}
public void setHealthCheckListener(Consumer<Boolean> healthListener) {
ScheduledExecutorService asyncHealthScheduler = Executors.newSingleThreadScheduledExecutor();
asyncHealthScheduler.scheduleAtFixedRate(() -> {
try (Connection c = dataSource.getConnection()) {
healthListener.accept(true);
} catch (SQLException ignored) {
healthListener.accept(false);
}
}, 0, 3, TimeUnit.SECONDS);
this.healthChecker = new DelegatedHealthChecker();
}
@Override
@ -93,7 +83,9 @@ public class JDBCHikariCPClient implements Client {
logger.debug("execute aql: {}", sql);
try (Statement statement = connection.createStatement()) {
statement.execute(sql);
healthChecker.health();
} catch (SQLException e) {
healthChecker.unHealth(e);
throw new JDBCClientException(e.getMessage(), e);
}
}
@ -107,6 +99,7 @@ public class JDBCHikariCPClient implements Client {
setStatementParam(statement, params);
result = statement.execute();
statement.closeOnCompletion();
healthChecker.health();
} catch (SQLException e) {
if (statement != null) {
try {
@ -114,6 +107,7 @@ public class JDBCHikariCPClient implements Client {
} catch (SQLException e1) {
}
}
healthChecker.unHealth(e);
throw new JDBCClientException(e.getMessage(), e);
}
@ -129,6 +123,7 @@ public class JDBCHikariCPClient implements Client {
setStatementParam(statement, params);
rs = statement.executeQuery();
statement.closeOnCompletion();
healthChecker.health();
} catch (SQLException e) {
if (statement != null) {
try {
@ -136,6 +131,7 @@ public class JDBCHikariCPClient implements Client {
} catch (SQLException e1) {
}
}
healthChecker.unHealth(e);
throw new JDBCClientException(e.getMessage(), e);
}
@ -161,4 +157,8 @@ public class JDBCHikariCPClient implements Client {
}
}
}
@Override public void registerChecker(HealthChecker healthChecker) {
this.healthChecker.register(healthChecker);
}
}

37
oap-server/server-library/library-util/src/main/java/org/apache/skywalking/oap/server/library/util/HealthChecker.java Normal file
View File

@ -0,0 +1,37 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
package org.apache.skywalking.oap.server.library.util;
/**
* Health checker provides methods to register the health status.
*/
public interface HealthChecker {
/**
* It's health.
*/
void health();
/**
* It's unHealth.
*
* @param t details of unhealthy status
*/
void unHealth(Throwable t);
}

7
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchProvider.java
View File

@ -74,6 +74,10 @@ import org.apache.skywalking.oap.server.storage.plugin.elasticsearch.query.TopNR
import org.apache.skywalking.oap.server.storage.plugin.elasticsearch.query.TopologyQueryEsDAO;
import org.apache.skywalking.oap.server.storage.plugin.elasticsearch.query.TraceQueryEsDAO;
import org.apache.skywalking.oap.server.storage.plugin.elasticsearch.query.UITemplateManagementEsDAO;
import org.apache.skywalking.oap.server.telemetry.TelemetryModule;
import org.apache.skywalking.oap.server.telemetry.api.HealthCheckMetrics;
import org.apache.skywalking.oap.server.telemetry.api.MetricsCreator;
import org.apache.skywalking.oap.server.telemetry.api.MetricsTag;
/**
* The storage provider for ElasticSearch 6.
@ -181,6 +185,9 @@ public class StorageModuleElasticsearchProvider extends ModuleProvider {
@Override
public void start() throws ModuleStartException {
MetricsCreator metricCreator = getManager().find(TelemetryModule.NAME).provider().getService(MetricsCreator.class);
HealthCheckMetrics healthChecker = metricCreator.createHealthCheckerGauge("storage_elasticsearch", MetricsTag.EMPTY_KEY, MetricsTag.EMPTY_VALUE);
elasticSearchClient.registerChecker(healthChecker);
try {
elasticSearchClient.connect();
StorageEsInstaller installer = new StorageEsInstaller(elasticSearchClient, getManager(), config);

7
oap-server/server-storage-plugin/storage-elasticsearch7-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch7/StorageModuleElasticsearch7Provider.java
View File

@ -70,6 +70,10 @@ import org.apache.skywalking.oap.server.storage.plugin.elasticsearch7.query.Meta
import org.apache.skywalking.oap.server.storage.plugin.elasticsearch7.query.MetricsQueryEs7DAO;
import org.apache.skywalking.oap.server.storage.plugin.elasticsearch7.query.ProfileThreadSnapshotQueryEs7DAO;
import org.apache.skywalking.oap.server.storage.plugin.elasticsearch7.query.TraceQueryEs7DAO;
import org.apache.skywalking.oap.server.telemetry.TelemetryModule;
import org.apache.skywalking.oap.server.telemetry.api.HealthCheckMetrics;
import org.apache.skywalking.oap.server.telemetry.api.MetricsCreator;
import org.apache.skywalking.oap.server.telemetry.api.MetricsTag;
import static org.apache.skywalking.oap.server.storage.plugin.elasticsearch.StorageModuleElasticsearchProvider.indexNameConverters;
@ -186,6 +190,9 @@ public class StorageModuleElasticsearch7Provider extends ModuleProvider {
@Override
public void start() throws ModuleStartException {
MetricsCreator metricCreator = getManager().find(TelemetryModule.NAME).provider().getService(MetricsCreator.class);
HealthCheckMetrics healthChecker = metricCreator.createHealthCheckerGauge("storage_elasticsearch", MetricsTag.EMPTY_KEY, MetricsTag.EMPTY_VALUE);
elasticSearch7Client.registerChecker(healthChecker);
try {
elasticSearch7Client.connect();

67
oap-server/server-storage-plugin/storage-elasticsearch7-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch7/client/ElasticSearch7Client.java
View File

@ -84,6 +84,8 @@ public class ElasticSearch7Client extends ElasticSearchClient {
@Override
public void connect() throws IOException, KeyStoreException, NoSuchAlgorithmException, KeyManagementException, CertificateException {
connectLock.lock();
try {
if (client != null) {
try {
client.close();
@ -94,6 +96,9 @@ public class ElasticSearch7Client extends ElasticSearchClient {
List<HttpHost> hosts = parseClusterNodes(protocol, clusterNodes);
client = createClient(hosts);
client.ping(RequestOptions.DEFAULT);
} finally {
connectLock.unlock();
}
}
public boolean createIndex(String indexName) throws IOException {
@ -124,7 +129,14 @@ public class ElasticSearch7Client extends ElasticSearchClient {
aliases = formatIndexName(aliases);
GetAliasesRequest getAliasesRequest = new GetAliasesRequest(aliases);
GetAliasesResponse alias = client.indices().getAlias(getAliasesRequest, RequestOptions.DEFAULT);
GetAliasesResponse alias;
try {
alias = client.indices().getAlias(getAliasesRequest, RequestOptions.DEFAULT);
healthChecker.health();
} catch (Throwable t) {
healthChecker.unHealth(t);
throw t;
}
return new ArrayList<>(alias.getAliases().keySet());
}
@ -184,13 +196,28 @@ public class ElasticSearch7Client extends ElasticSearchClient {
indexName = formatIndexName(indexName);
SearchRequest searchRequest = new SearchRequest(indexName);
searchRequest.source(searchSourceBuilder);
return client.search(searchRequest, RequestOptions.DEFAULT);
try {
SearchResponse response = client.search(searchRequest, RequestOptions.DEFAULT);
healthChecker.health();
return response;
} catch (Throwable t) {
healthChecker.unHealth(t);
handleIOPoolStopped(t);
throw t;
}
}
public GetResponse get(String indexName, String id) throws IOException {
indexName = formatIndexName(indexName);
GetRequest request = new GetRequest(indexName, id);
return client.get(request, RequestOptions.DEFAULT);
try {
GetResponse response = client.get(request, RequestOptions.DEFAULT);
healthChecker.health();
return response;
} catch (Throwable t) {
healthChecker.unHealth(t);
throw t;
}
}
public SearchResponse ids(String indexName, String[] ids) throws IOException {
@ -198,30 +225,39 @@ public class ElasticSearch7Client extends ElasticSearchClient {
SearchRequest searchRequest = new SearchRequest(indexName);
searchRequest.source().query(QueryBuilders.idsQuery().addIds(ids)).size(ids.length);
return client.search(searchRequest, RequestOptions.DEFAULT);
try {
SearchResponse response = client.search(searchRequest, RequestOptions.DEFAULT);
healthChecker.health();
return response;
} catch (Throwable t) {
healthChecker.unHealth(t);
throw t;
}
}
public void forceInsert(String indexName, String id, XContentBuilder source) throws IOException {
IndexRequest request = (IndexRequest) prepareInsert(indexName, id, source);
request.setRefreshPolicy(WriteRequest.RefreshPolicy.IMMEDIATE);
try {
client.index(request, RequestOptions.DEFAULT);
healthChecker.health();
} catch (Throwable t) {
healthChecker.unHealth(t);
throw t;
}
public void forceUpdate(String indexName, String id, XContentBuilder source, long seqNo,
long primaryTerm) throws IOException {
org.elasticsearch.action.update.UpdateRequest request = (org.elasticsearch.action.update.UpdateRequest) prepareUpdate(
indexName, id, source);
request.setIfSeqNo(seqNo);
request.setIfPrimaryTerm(primaryTerm);
request.setRefreshPolicy(WriteRequest.RefreshPolicy.IMMEDIATE);
client.update(request, RequestOptions.DEFAULT);
}
public void forceUpdate(String indexName, String id, XContentBuilder source) throws IOException {
org.elasticsearch.action.update.UpdateRequest request = (org.elasticsearch.action.update.UpdateRequest) prepareUpdate(
indexName, id, source);
request.setRefreshPolicy(WriteRequest.RefreshPolicy.IMMEDIATE);
try {
client.update(request, RequestOptions.DEFAULT);
healthChecker.health();
} catch (Throwable t) {
healthChecker.unHealth(t);
throw t;
}
}
public InsertRequest prepareInsert(String indexName, String id, XContentBuilder source) {
@ -256,8 +292,9 @@ public class ElasticSearch7Client extends ElasticSearchClient {
int size = request.requests().size();
BulkResponse responses = client.bulk(request, RequestOptions.DEFAULT);
log.info("Synchronous bulk took time: {} millis, size: {}", responses.getTook().getMillis(), size);
} catch (IOException e) {
log.error(e.getMessage(), e);
healthChecker.health();
} catch (Throwable t) {
healthChecker.unHealth(t);
}
}

13
oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/H2StorageProvider.java
View File

@ -64,7 +64,7 @@ import org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2TopologyQue
import org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2TraceQueryDAO;
import org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2UITemplateManagementDAO;
import org.apache.skywalking.oap.server.telemetry.TelemetryModule;
import org.apache.skywalking.oap.server.telemetry.api.GaugeMetrics;
import org.apache.skywalking.oap.server.telemetry.api.HealthCheckMetrics;
import org.apache.skywalking.oap.server.telemetry.api.MetricsCreator;
import org.apache.skywalking.oap.server.telemetry.api.MetricsTag;
@ -136,8 +136,8 @@ public class H2StorageProvider extends ModuleProvider {
@Override
public void start() throws ServiceNotProvidedException, ModuleStartException {
MetricsCreator metricCreator = getManager().find(TelemetryModule.NAME).provider().getService(MetricsCreator.class);
GaugeMetrics healthChecker = metricCreator.createHealthCheckerGauge("storage_h2", MetricsTag.EMPTY_KEY, MetricsTag.EMPTY_VALUE);
healthChecker.setValue(1);
HealthCheckMetrics healthChecker = metricCreator.createHealthCheckerGauge("storage_h2", MetricsTag.EMPTY_KEY, MetricsTag.EMPTY_VALUE);
h2Client.registerChecker(healthChecker);
try {
h2Client.connect();
@ -146,13 +146,6 @@ public class H2StorageProvider extends ModuleProvider {
} catch (StorageException e) {
throw new ModuleStartException(e.getMessage(), e);
}
h2Client.setHealthCheckListener(isHealthy -> {
if (isHealthy) {
healthChecker.setValue(0);
} else {
healthChecker.setValue(1);
}
});
}
@Override

45
oap-server/server-telemetry/telemetry-api/src/main/java/org/apache/skywalking/oap/server/telemetry/api/HealthCheckMetrics.java Normal file
View File

@ -0,0 +1,45 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
package org.apache.skywalking.oap.server.telemetry.api;
import lombok.extern.slf4j.Slf4j;
import org.apache.skywalking.oap.server.library.util.HealthChecker;
/**
* HealthCheckMetrics intends to record health status.
*/
@Slf4j
public class HealthCheckMetrics implements HealthChecker {
private final GaugeMetrics metrics;
public HealthCheckMetrics(GaugeMetrics metrics) {
this.metrics = metrics;
// The initial status is unhealthy with -1 code.
metrics.setValue(-1);
}
public void health() {
metrics.setValue(0);
}
public void unHealth(Throwable t) {
log.error("Health check fails", t);
metrics.setValue(1);
}
}

6
oap-server/server-telemetry/telemetry-api/src/main/java/org/apache/skywalking/oap/server/telemetry/api/MetricsCreator.java
View File

@ -50,11 +50,11 @@ public interface MetricsCreator extends Service {
/**
* Create a Health Check gauge.
*/
default GaugeMetrics createHealthCheckerGauge(String name, MetricsTag.Keys tagKeys, MetricsTag.Values tagValues) {
default HealthCheckMetrics createHealthCheckerGauge(String name, MetricsTag.Keys tagKeys, MetricsTag.Values tagValues) {
Preconditions.checkArgument(!Strings.isNullOrEmpty(name), "Require non-null or empty metric name");
return createGauge(Strings.lenientFormat("%s%s", HEALTH_METRIC_PREFIX, name),
return new HealthCheckMetrics(createGauge(Strings.lenientFormat("%s%s", HEALTH_METRIC_PREFIX, name),
Strings.lenientFormat("%s health check", name),
tagKeys, tagValues);
tagKeys, tagValues));
}
/**