diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index 09de7230c4..4e447b4d12 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -50,6 +50,7 @@ * Apply MQE on Virtual-Cache layer UI-templates * Add Echo component ID(5015) language: Golang. * Fix `index out of bounds exception` in `aggregate_labels` MQE function. +* Do not print configurations values in logs to avoid sensitive info leaked. * Move created the latest index before retrieval indexes by aliases to avoid the 404 exception. This just prevents some interference from manual operations. #### UI diff --git a/oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/config/ApplicationConfigLoader.java b/oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/config/ApplicationConfigLoader.java index 3bccd303a9..048a169701 100644 --- a/oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/config/ApplicationConfigLoader.java +++ b/oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/config/ApplicationConfigLoader.java @@ -18,19 +18,20 @@ package org.apache.skywalking.oap.server.starter.config; +import lombok.extern.slf4j.Slf4j; +import org.apache.skywalking.oap.server.library.module.ApplicationConfiguration; +import org.apache.skywalking.oap.server.library.module.ProviderNotFoundException; +import org.apache.skywalking.oap.server.library.util.CollectionUtils; +import org.apache.skywalking.oap.server.library.util.PropertyPlaceholderHelper; +import org.apache.skywalking.oap.server.library.util.ResourceUtils; +import org.yaml.snakeyaml.Yaml; + import java.io.FileNotFoundException; import java.io.Reader; import java.util.ArrayList; import java.util.Iterator; import java.util.Map; import java.util.Properties; -import lombok.extern.slf4j.Slf4j; -import org.apache.skywalking.oap.server.library.util.PropertyPlaceholderHelper; -import org.apache.skywalking.oap.server.library.module.ApplicationConfiguration; -import org.apache.skywalking.oap.server.library.module.ProviderNotFoundException; -import org.apache.skywalking.oap.server.library.util.CollectionUtils; -import org.apache.skywalking.oap.server.library.util.ResourceUtils; -import org.yaml.snakeyaml.Yaml; /** * Initialize collector settings with following sources. Use application.yml as primary setting, and fix missing setting @@ -76,7 +77,7 @@ public class ApplicationConfigLoader implements ConfigLoader { if (propertyValue instanceof Map) { Properties subProperties = new Properties(); - ((Map) propertyValue).forEach((key, value) -> { + ((Map) propertyValue).forEach((key, value) -> { subProperties.put(key, value); replacePropertyAndLog(key, value, subProperties, providerName); }); @@ -102,26 +103,18 @@ public class ApplicationConfigLoader implements ConfigLoader