Commit Graph

10 Commits

Author SHA1 Message Date
Stephen Ni d4ea997523
chore: add @Override tag on some methods (#6304) 2021-02-03 09:46:57 +08:00
Lu Jiajing 5bfac1b50f
Remove style-check exception for logger (#5363) 2020-08-21 18:26:25 +08:00
mrproliu 4e821415ea
Fix profile recheck error (#4690) 2020-04-22 19:25:56 +08:00
kezhenxu94 dcd66ee6e9
Rewrite the E2E test framework and tests (#4510)
Motivation:

According the feedback from the community, the e2e tests are hard for
them to understand and get them started, so this pull request aims to
rewrite the e2e tests with some improvements:

- debuggable locally, now you can run every individual case directly
inside the IDE, just like running a plain unit test.

- same functionalities of multiple counterparts share the same codes,
cases like different storages and cluster coordinators share the same
codes, easy to add more similar cases.

- the "end" now extends to the Doccker images, meaning that some bugs
like #4483 and #4471 can be more easily and early to be discovered.

- codes style and license headers are checked

Modifications:

- adopt jupeter (a.k.a junit 5), testcontainers as the new test
framework, all containers are orchestrated by docker-compose.yml,
well-known technology that developers should be familiar with.

- rewrite all test cases and verify them.

- reorganize the workflows in GitHub Actions.

Result:

- new e2e test should be easy to add.

- closes https://github.com/apache/skywalking/issues/4472
2020-03-16 23:45:14 +08:00
kezhenxu94 5b255ba3e3
Set up more strict code styles and fix existing issues (#4337)
Motivation:

Review code styles with some bots automatically.

Modifications:

Set up ReviewDog in GitHub Action to review code style.

Add more check rules to checkstyle plugin.

Result:

Obvious code styles can be reviewed and commented automatically.
2020-02-11 17:10:49 +08:00
kezhenxu94 80f779c75c Check package name org.apache.skywalking (#3581)
* Check package name org.apache.skywalking

* Only check REAL sources
2019-10-09 23:32:37 +08:00
kezhenxu94 ca80e457cc Add bootstrap-plugin/toolkit-activation to import check list (#3290) 2019-08-20 09:56:41 +08:00
kezhenxu94 db9759fcc2 Check license header strictly (#3274)
* Check license header strictly

* Ignore header template

* Include more files to check list
2019-08-16 14:37:44 +08:00
Daming 8f76ff2fe6 add optional-plugins into ImportControl check list (#3061) 2019-07-12 19:24:51 +08:00
kezhenxu94 48835348bb Check disallowed imports in agent instrumentation classes (#2908)
* Check disallowed imports in agent instrumentation classes

* Remove check script

* Remove script
2019-06-19 14:04:22 +08:00