kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change the Apdex metric combine calculator (#6363)

This commit is contained in:
mrproliu 2021-02-11 15:19:32 +08:00 committed by GitHub
parent 92d0465cd8
commit fcf64a217f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES.md
View File

@ -19,6 +19,7 @@ Release Notes.
* Add some defensive codes for NPE and bump up Kubernetes client version to expose exception stack trace. * Add some defensive codes for NPE and bump up Kubernetes client version to expose exception stack trace.
* Update the `timestamp` field type for `LogQuery`. * Update the `timestamp` field type for `LogQuery`.
* Support Zabbix protocol to receive agent metrics. * Support Zabbix protocol to receive agent metrics.
* Update the Apdex metric combine calculator.
#### UI #### UI
* Update selector scroller to show in all pages. * Update selector scroller to show in all pages.

4
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/ApdexMetrics.java
View File

@ -68,10 +68,10 @@ public abstract class ApdexMetrics extends Metrics implements IntValueHolder {
int t = DICT.lookup(name).intValue(); int t = DICT.lookup(name).intValue();
int t4 = t * 4; int t4 = t * 4;
totalNum++; totalNum++;
if (!status || value >= t4) { if (!status || value > t4) {
return; return;
} }
if (value >= t) { if (value > t) {
tNum++; tNum++;
} else { } else {
sNum++; sNum++;

2
oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/analysis/metrics/ApdexMetricsTest.java
View File

@ -47,7 +47,7 @@ public class ApdexMetricsTest {
apdex = new ApdexMetricsImpl(); apdex = new ApdexMetricsImpl();
apdex.combine(2000, "foo", true); apdex.combine(2000, "foo", true);
apdex.calculate(); apdex.calculate();
assertThat(apdex.getValue(), is(0)); assertThat(apdex.getValue(), is(5000));
apdex = new ApdexMetricsImpl(); apdex = new ApdexMetricsImpl();
apdex.combine(200, "foo", true); apdex.combine(200, "foo", true);