From fb1983937e5b3dcc10115cc086dfd744656beba3 Mon Sep 17 00:00:00 2001 From: Oliver Date: Mon, 4 Apr 2022 20:34:10 +0800 Subject: [PATCH] [Chore] Fix comment's grammar and modifier's order (#138) --- .../apm/commons/datacarrier/consumer/BulkConsumePool.java | 2 +- .../skywalking/apm/agent/core/context/ContextManager.java | 2 +- .../skywalking/apm/plugin/asf/dubbo/DubboInterceptor.java | 2 +- .../skywalking/apm/plugin/asf/dubbo3/DubboInterceptor.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/consumer/BulkConsumePool.java b/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/consumer/BulkConsumePool.java index 2d2195d3f..c753e4886 100644 --- a/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/consumer/BulkConsumePool.java +++ b/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/consumer/BulkConsumePool.java @@ -45,7 +45,7 @@ public class BulkConsumePool implements ConsumerPool { } @Override - synchronized public void add(String name, Channels channels, IConsumer consumer) { + public synchronized void add(String name, Channels channels, IConsumer consumer) { MultipleChannelsConsumer multipleChannelsConsumer = getLowestPayload(); multipleChannelsConsumer.addNewTarget(channels, consumer); } diff --git a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java index 2caaa0d31..44dc57575 100644 --- a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java +++ b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java @@ -169,7 +169,7 @@ public class ContextManager implements BootService { } /** - * If not sure has the active span, use this method, will be cause NPE when has no active span, use + * Using this method will cause NPE if active span does not exist. If one is not sure whether there is an active span, use * ContextManager::isActive method to determine whether there has the active span. */ public static AbstractSpan activeSpan() { diff --git a/apm-sniffer/apm-sdk-plugin/dubbo-2.7.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo/DubboInterceptor.java b/apm-sniffer/apm-sdk-plugin/dubbo-2.7.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo/DubboInterceptor.java index 4aff0bf80..d35bb0baf 100644 --- a/apm-sniffer/apm-sdk-plugin/dubbo-2.7.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo/DubboInterceptor.java +++ b/apm-sniffer/apm-sdk-plugin/dubbo-2.7.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo/DubboInterceptor.java @@ -53,7 +53,7 @@ public class DubboInterceptor implements InstanceMethodsAroundInterceptor { * inject to the {@link RpcContext#attachments} for transport to provider side. *

*

Provider:

The serialized trace context data will extract from - * {@link RpcContext#attachments}. current trace segment will ref if the serialize context data is not null. + * {@link RpcContext#attachments}. current trace segment will ref if the serialization context data is not null. */ @Override public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class[] argumentsTypes, diff --git a/apm-sniffer/apm-sdk-plugin/dubbo-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo3/DubboInterceptor.java b/apm-sniffer/apm-sdk-plugin/dubbo-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo3/DubboInterceptor.java index b31db6d58..9ff83561e 100644 --- a/apm-sniffer/apm-sdk-plugin/dubbo-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo3/DubboInterceptor.java +++ b/apm-sniffer/apm-sdk-plugin/dubbo-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo3/DubboInterceptor.java @@ -54,7 +54,7 @@ public class DubboInterceptor implements InstanceMethodsAroundInterceptor { * inject to the {@link RpcContext#getClientAttachment} for transport to provider side. *

*

Provider:

The serialized trace context data will extract from - * {@link RpcContext#getServerAttachment}. current trace segment will ref if the serialize context data is not + * {@link RpcContext#getServerAttachment}. current trace segment will ref if the serialization context data is not * null. */ @Override