From fa81a0f6ba347a246f1e7b9cd590373fbb4dcd29 Mon Sep 17 00:00:00 2001 From: wusheng Date: Wed, 22 Mar 2017 16:51:56 +0800 Subject: [PATCH] Check sampling mechanism. --- .../com/a/eye/skywalking/api/sampling/SamplingService.java | 1 + .../a/eye/skywalking/api/context/TracerContextTestCase.java | 1 + .../a/eye/skywalking/api/sampling/SamplingServiceTest.java | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/skywalking-sniffer/skywalking-api/src/main/java/com/a/eye/skywalking/api/sampling/SamplingService.java b/skywalking-sniffer/skywalking-api/src/main/java/com/a/eye/skywalking/api/sampling/SamplingService.java index a2bfa0a2d..dd6572f97 100644 --- a/skywalking-sniffer/skywalking-api/src/main/java/com/a/eye/skywalking/api/sampling/SamplingService.java +++ b/skywalking-sniffer/skywalking-api/src/main/java/com/a/eye/skywalking/api/sampling/SamplingService.java @@ -40,6 +40,7 @@ public class SamplingService implements BootService { if (on) { if (rollingSeed % Config.Agent.SAMPLING_CYCLE != 0) { segment.setSampled(false); + this.rollingSeed = 1; } rollingSeed++; } diff --git a/skywalking-sniffer/skywalking-api/src/test/java/com/a/eye/skywalking/api/context/TracerContextTestCase.java b/skywalking-sniffer/skywalking-api/src/test/java/com/a/eye/skywalking/api/context/TracerContextTestCase.java index 3b62a2780..308d72801 100644 --- a/skywalking-sniffer/skywalking-api/src/test/java/com/a/eye/skywalking/api/context/TracerContextTestCase.java +++ b/skywalking-sniffer/skywalking-api/src/test/java/com/a/eye/skywalking/api/context/TracerContextTestCase.java @@ -5,6 +5,7 @@ import com.a.eye.skywalking.trace.TraceId.DistributedTraceId; import com.a.eye.skywalking.trace.TraceId.PropagatedTraceId; import com.a.eye.skywalking.trace.TraceSegment; import com.a.eye.skywalking.trace.tag.Tags; +import java.awt.SystemTray; import java.util.LinkedList; import java.util.List; import org.junit.After; diff --git a/skywalking-sniffer/skywalking-api/src/test/java/com/a/eye/skywalking/api/sampling/SamplingServiceTest.java b/skywalking-sniffer/skywalking-api/src/test/java/com/a/eye/skywalking/api/sampling/SamplingServiceTest.java index d3d406cad..36bb9799c 100644 --- a/skywalking-sniffer/skywalking-api/src/test/java/com/a/eye/skywalking/api/sampling/SamplingServiceTest.java +++ b/skywalking-sniffer/skywalking-api/src/test/java/com/a/eye/skywalking/api/sampling/SamplingServiceTest.java @@ -26,6 +26,10 @@ public class SamplingServiceTest { segment = new TraceSegment(); service.trySampling(segment); Assert.assertTrue(segment.isSampled()); + + segment = new TraceSegment(); + service.trySampling(segment); + Assert.assertFalse(segment.isSampled()); } @AfterClass