From ec2a2d4188b78562ed41c9fb1115d86f5dfdc847 Mon Sep 17 00:00:00 2001 From: githubcheng2978 Date: Fri, 26 Apr 2024 22:09:36 +0800 Subject: [PATCH] Use a daemon thread to flush logs. (#684) --- CHANGES.md | 1 + .../skywalking/apm/agent/core/logging/core/FileWriter.java | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index 790ba4c6d..ba2cd6cb7 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -8,6 +8,7 @@ Release Notes. * Remove `idleCount` tag in Alibaba Druid meter plugin. * Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. * Support for C3P0 connection pool tracing. +* Use a daemon thread to flush logs. All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/213?closed=1) diff --git a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/FileWriter.java b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/FileWriter.java index 4020b7a98..adc7194e4 100644 --- a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/FileWriter.java +++ b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/FileWriter.java @@ -97,6 +97,7 @@ public class FileWriter implements IWriter { public void handle(Throwable t) { } }), "SkywalkingAgent-LogFileWriter"); + logFlusherThread.setDaemon(true); logFlusherThread.start(); }