From e9196b7e204fe2737f4a719069d638ac38b1e33e Mon Sep 17 00:00:00 2001 From: mantuliu <240951888@qq.com> Date: Mon, 8 Mar 2021 12:37:10 +0800 Subject: [PATCH] remove meaningless code (#6508) --- .../plugin/jdbc/h2/dao/H2TraceQueryDAO.java | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java b/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java index f09c152ea..18971ec9d 100644 --- a/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java +++ b/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java @@ -99,15 +99,13 @@ public class H2TraceQueryDAO implements ITraceQueryDAO { sql.append(" and ").append(SegmentRecord.TIME_BUCKET).append(" <= ?"); parameters.add(endSecondTB); } - if (minDuration != 0 || maxDuration != 0) { - if (minDuration != 0) { - sql.append(" and ").append(SegmentRecord.LATENCY).append(" >= ?"); - parameters.add(minDuration); - } - if (maxDuration != 0) { - sql.append(" and ").append(SegmentRecord.LATENCY).append(" <= ?"); - parameters.add(maxDuration); - } + if (minDuration != 0) { + sql.append(" and ").append(SegmentRecord.LATENCY).append(" >= ?"); + parameters.add(minDuration); + } + if (maxDuration != 0) { + sql.append(" and ").append(SegmentRecord.LATENCY).append(" <= ?"); + parameters.add(maxDuration); } if (!Strings.isNullOrEmpty(endpointName)) { sql.append(" and ").append(SegmentRecord.ENDPOINT_NAME).append(" like concat('%',?,'%')");