Print gloablTraceId insteadof segementTraceId, in log and context toolkits.

This commit is contained in:
wusheng 2017-04-07 12:05:28 +08:00
parent 0a33b1249d
commit e50dc3da2d
6 changed files with 10 additions and 21 deletions

View File

@ -1,7 +1,6 @@
package com.a.eye.skywalking.api.context;
import com.a.eye.skywalking.api.boot.BootService;
import com.a.eye.skywalking.api.queue.TraceSegmentProcessQueue;
import com.a.eye.skywalking.trace.Span;
import com.a.eye.skywalking.trace.TraceSegment;
@ -44,21 +43,14 @@ public class ContextManager implements TracerContextListener, BootService {
}
/**
* @see {@link TracerContext#extract(ContextCarrier)}
* @return the first global trace id if exist. Otherwise, "N/A".
*/
public static void multiExtract(ContextCarrier carrier){
get().extract(carrier);
}
/**
* @return the {@link TraceSegment#traceSegmentId} if exist. Otherwise, "N/A".
*/
public static String getTraceSegmentId(){
public static String getGlobalTraceId(){
TracerContext segment = CONTEXT.get();
if(segment == null){
return "N/A";
}else{
return segment.getTraceSegmentId();
return segment.getGlobalTraceId();
}
}

View File

@ -91,10 +91,10 @@ public final class TracerContext {
}
/**
* @return the current trace segment id.
* @return the current trace id.
*/
String getTraceSegmentId(){
return segment.getTraceSegmentId();
String getGlobalTraceId(){
return segment.getRelatedGlobalTraces().get(0).get();
}
public void stopSpan(Span span, Long endTime){

View File

@ -1,6 +1,5 @@
package com.a.eye.skywalking.toolkit.activation.log.log4j.v1.x;
import com.a.eye.skywalking.api.context.ContextCarrier;
import com.a.eye.skywalking.api.context.ContextManager;
import com.a.eye.skywalking.api.plugin.interceptor.EnhancedClassInstanceContext;
import com.a.eye.skywalking.api.plugin.interceptor.enhance.InstanceMethodInvokeContext;
@ -26,7 +25,7 @@ public class PrintTraceIdInterceptor implements InstanceMethodsAroundInterceptor
*/
@Override
public Object afterMethod(EnhancedClassInstanceContext context, InstanceMethodInvokeContext interceptorContext, Object ret) {
return "TID:" + ContextManager.getTraceSegmentId();
return "TID:" + ContextManager.getGlobalTraceId();
}
@Override

View File

@ -1,6 +1,5 @@
package com.a.eye.skywalking.toolkit.activation.log.log4j.v2.x;
import com.a.eye.skywalking.api.context.ContextCarrier;
import com.a.eye.skywalking.api.context.ContextManager;
import com.a.eye.skywalking.api.plugin.interceptor.enhance.MethodInterceptResult;
import com.a.eye.skywalking.api.plugin.interceptor.enhance.MethodInvokeContext;
@ -19,7 +18,7 @@ public class PrintTraceIdInterceptor implements StaticMethodsAroundInterceptor {
*/
@Override
public void beforeMethod(StaticMethodInvokeContext interceptorContext, MethodInterceptResult result) {
((StringBuilder) interceptorContext.allArguments()[0]).append("TID:" + ContextManager.getTraceSegmentId());
((StringBuilder) interceptorContext.allArguments()[0]).append("TID:" + ContextManager.getGlobalTraceId());
//make sure origin method do not invoke.
result.defineReturnValue(null);

View File

@ -25,7 +25,7 @@ public class PrintTraceIdInterceptor implements InstanceMethodsAroundInterceptor
*/
@Override
public Object afterMethod(EnhancedClassInstanceContext context, InstanceMethodInvokeContext interceptorContext, Object ret) {
return "TID:" + ContextManager.getTraceSegmentId();
return "TID:" + ContextManager.getGlobalTraceId();
}
@Override

View File

@ -1,6 +1,5 @@
package com.a.eye.skywalking.toolkit.activation.trace;
import com.a.eye.skywalking.api.context.ContextCarrier;
import com.a.eye.skywalking.api.context.ContextManager;
import com.a.eye.skywalking.logging.ILog;
import com.a.eye.skywalking.logging.LogManager;
@ -24,7 +23,7 @@ public class TraceContextInterceptor implements StaticMethodsAroundInterceptor {
@Override
public Object afterMethod(StaticMethodInvokeContext interceptorContext, Object ret) {
return ContextManager.getTraceSegmentId();
return ContextManager.getGlobalTraceId();
}
@Override