From d5348c93dee66adae4230eb88618c007eec768e5 Mon Sep 17 00:00:00 2001 From: Leon Yang <1395305816@qq.com> Date: Wed, 2 Jun 2021 23:18:31 +0800 Subject: [PATCH] Fix: TraceIgnorePathPatterns can't set empty value (#7059) --- CHANGES.md | 1 + .../apm/plugin/trace/ignore/TraceIgnoreExtendService.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index d741d935d..632f88d5a 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -33,6 +33,7 @@ Release Notes. * Fix ClassCast issue for RequestHolder/ResponseHolder. * fixed `jdk-threading-plugin` memory leak. * Optimize multiple field reflection operation in Feign plugin. +* Fix `trace-ignore-plugin` TraceIgnorePathPatterns can't set empty value #### OAP-Backend * BugFix: filter invalid Envoy access logs whose socket address is empty. diff --git a/apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/TraceIgnoreExtendService.java b/apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/TraceIgnoreExtendService.java index 5f4dc6afd..eaabd0ebd 100644 --- a/apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/TraceIgnoreExtendService.java +++ b/apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/TraceIgnoreExtendService.java @@ -89,6 +89,8 @@ public class TraceIgnoreExtendService extends SamplingService { void handleTraceIgnorePatternsChanged() { if (StringUtil.isNotBlank(traceIgnorePatternWatcher.getTraceIgnorePathPatterns())) { patterns = traceIgnorePatternWatcher.getTraceIgnorePathPatterns().split(PATTERN_SEPARATOR); + } else { + patterns = new String[] {}; } } }