From 39e414b6807f3b68dd79054059c11c57a370ca1e Mon Sep 17 00:00:00 2001 From: xcaspar Date: Mon, 1 May 2017 21:46:22 +0800 Subject: [PATCH] chore(collector): add a check for process id in startup script --- .../bin/collector-service.sh | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/apm-collector/apm-collector-worker/bin/collector-service.sh b/apm-collector/apm-collector-worker/bin/collector-service.sh index 542bc6117..e6e1f9c37 100644 --- a/apm-collector/apm-collector-worker/bin/collector-service.sh +++ b/apm-collector/apm-collector-worker/bin/collector-service.sh @@ -24,10 +24,14 @@ echo "Starting collector...." eval exec "\"$_RUNJAVA\" ${JAVA_OPTS} -classpath $CLASSPATH CollectorBootStartUp \ 2>${COLLECTOR_LOGS_DIR}/collector.log 1> /dev/null &" -if [ $? -eq 0 ]; then - sleep 1 - echo "Collector started successfully!" -else - echo "Collector started failure!" - exit 1 +retval=$? +pid=$! +FAIL_MSG="Collector started failure!" +SUCCESS_MSG="Collector started successfully!" +[ ${retval} -eq 0 ] || (echo ${FAIL_MSG}; exit ${retval}) +sleep 1 +if ! ps -p ${pid} > /dev/null ; then + echo ${FAIL_MSG} + exit 1 fi +echo ${SUCCESS_MSG}