From b9404f6a97b2ee047c83c1b4849e0a14cf80c5c3 Mon Sep 17 00:00:00 2001
From: pengys5 <8082209@qq.com>
Date: Fri, 11 Aug 2017 11:19:13 +0800
Subject: [PATCH] Throw UnexpectedException when invoke deserialize or
 serialize method in GC,CPU,MEMORY,MEMORY POOL data define.

---
 .../worker/cpu/define/CpuMetricDataDefine.java        |  5 +++--
 .../agentjvm/worker/gc/define/GCMetricDataDefine.java |  5 +++--
 .../worker/memory/define/MemoryMetricDataDefine.java  |  5 +++--
 .../memorypool/define/MemoryPoolMetricDataDefine.java |  5 +++--
 .../collector/core/framework/UnexpectedException.java | 11 +++++++++++
 5 files changed, 23 insertions(+), 8 deletions(-)
 create mode 100644 apm-collector/apm-collector-core/src/main/java/org/skywalking/apm/collector/core/framework/UnexpectedException.java

diff --git a/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/cpu/define/CpuMetricDataDefine.java b/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/cpu/define/CpuMetricDataDefine.java
index 77923eb66..2622e2e95 100644
--- a/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/cpu/define/CpuMetricDataDefine.java
+++ b/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/cpu/define/CpuMetricDataDefine.java
@@ -1,5 +1,6 @@
 package org.skywalking.apm.collector.agentjvm.worker.cpu.define;
 
+import org.skywalking.apm.collector.core.framework.UnexpectedException;
 import org.skywalking.apm.collector.remote.grpc.proto.RemoteData;
 import org.skywalking.apm.collector.stream.worker.impl.data.Attribute;
 import org.skywalking.apm.collector.stream.worker.impl.data.AttributeType;
@@ -26,11 +27,11 @@ public class CpuMetricDataDefine extends DataDefine {
     }
 
     @Override public Object deserialize(RemoteData remoteData) {
-        return null;
+        throw new UnexpectedException("cpu metric data did not need send to remote worker.");
     }
 
     @Override public RemoteData serialize(Object object) {
-        return null;
+        throw new UnexpectedException("cpu metric data did not need send to remote worker.");
     }
 
     public static class CpuMetric implements Transform<CpuMetric> {
diff --git a/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/gc/define/GCMetricDataDefine.java b/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/gc/define/GCMetricDataDefine.java
index 953f38caf..a579cda1f 100644
--- a/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/gc/define/GCMetricDataDefine.java
+++ b/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/gc/define/GCMetricDataDefine.java
@@ -1,5 +1,6 @@
 package org.skywalking.apm.collector.agentjvm.worker.gc.define;
 
+import org.skywalking.apm.collector.core.framework.UnexpectedException;
 import org.skywalking.apm.collector.remote.grpc.proto.RemoteData;
 import org.skywalking.apm.collector.stream.worker.impl.data.Attribute;
 import org.skywalking.apm.collector.stream.worker.impl.data.AttributeType;
@@ -28,11 +29,11 @@ public class GCMetricDataDefine extends DataDefine {
     }
 
     @Override public Object deserialize(RemoteData remoteData) {
-        return null;
+        throw new UnexpectedException("gc metric data did not need send to remote worker.");
     }
 
     @Override public RemoteData serialize(Object object) {
-        return null;
+        throw new UnexpectedException("gc metric data did not need send to remote worker.");
     }
 
     public static class GCMetric implements Transform<GCMetric> {
diff --git a/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/memory/define/MemoryMetricDataDefine.java b/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/memory/define/MemoryMetricDataDefine.java
index 636afb505..927458e83 100644
--- a/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/memory/define/MemoryMetricDataDefine.java
+++ b/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/memory/define/MemoryMetricDataDefine.java
@@ -1,5 +1,6 @@
 package org.skywalking.apm.collector.agentjvm.worker.memory.define;
 
+import org.skywalking.apm.collector.core.framework.UnexpectedException;
 import org.skywalking.apm.collector.remote.grpc.proto.RemoteData;
 import org.skywalking.apm.collector.stream.worker.impl.data.Attribute;
 import org.skywalking.apm.collector.stream.worker.impl.data.AttributeType;
@@ -30,11 +31,11 @@ public class MemoryMetricDataDefine extends DataDefine {
     }
 
     @Override public Object deserialize(RemoteData remoteData) {
-        return null;
+        throw new UnexpectedException("memory metric data did not need send to remote worker.");
     }
 
     @Override public RemoteData serialize(Object object) {
-        return null;
+        throw new UnexpectedException("memory metric data did not need send to remote worker.");
     }
 
     public static class MemoryMetric implements Transform<MemoryMetric> {
diff --git a/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/memorypool/define/MemoryPoolMetricDataDefine.java b/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/memorypool/define/MemoryPoolMetricDataDefine.java
index f80c497fd..dd2daaad3 100644
--- a/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/memorypool/define/MemoryPoolMetricDataDefine.java
+++ b/apm-collector/apm-collector-agentjvm/src/main/java/org/skywalking/apm/collector/agentjvm/worker/memorypool/define/MemoryPoolMetricDataDefine.java
@@ -1,5 +1,6 @@
 package org.skywalking.apm.collector.agentjvm.worker.memorypool.define;
 
+import org.skywalking.apm.collector.core.framework.UnexpectedException;
 import org.skywalking.apm.collector.remote.grpc.proto.RemoteData;
 import org.skywalking.apm.collector.stream.worker.impl.data.Attribute;
 import org.skywalking.apm.collector.stream.worker.impl.data.AttributeType;
@@ -31,11 +32,11 @@ public class MemoryPoolMetricDataDefine extends DataDefine {
     }
 
     @Override public Object deserialize(RemoteData remoteData) {
-        return null;
+        throw new UnexpectedException("memory pool metric data did not need send to remote worker.");
     }
 
     @Override public RemoteData serialize(Object object) {
-        return null;
+        throw new UnexpectedException("memory pool metric data did not need send to remote worker.");
     }
 
     public static class MemoryPoolMetric implements Transform<MemoryPoolMetric> {
diff --git a/apm-collector/apm-collector-core/src/main/java/org/skywalking/apm/collector/core/framework/UnexpectedException.java b/apm-collector/apm-collector-core/src/main/java/org/skywalking/apm/collector/core/framework/UnexpectedException.java
new file mode 100644
index 000000000..a764cdfc9
--- /dev/null
+++ b/apm-collector/apm-collector-core/src/main/java/org/skywalking/apm/collector/core/framework/UnexpectedException.java
@@ -0,0 +1,11 @@
+package org.skywalking.apm.collector.core.framework;
+
+/**
+ * @author pengys5
+ */
+public class UnexpectedException extends RuntimeException {
+
+    public UnexpectedException(String message) {
+        super(message);
+    }
+}