From b63f8bca8bd8e6cfcbb1a4965436256b883432c8 Mon Sep 17 00:00:00 2001 From: cyejing Date: Wed, 6 Nov 2019 21:23:26 +0800 Subject: [PATCH] fix opentracing with tag error is failed (#3795) --- .../activation/opentracing/span/SpanSetTagInterceptor.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apm-sniffer/apm-toolkit-activation/apm-toolkit-opentracing-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/opentracing/span/SpanSetTagInterceptor.java b/apm-sniffer/apm-toolkit-activation/apm-toolkit-opentracing-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/opentracing/span/SpanSetTagInterceptor.java index e6f8657e5..0af8c5c3c 100644 --- a/apm-sniffer/apm-toolkit-activation/apm-toolkit-opentracing-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/opentracing/span/SpanSetTagInterceptor.java +++ b/apm-sniffer/apm-toolkit-activation/apm-toolkit-opentracing-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/opentracing/span/SpanSetTagInterceptor.java @@ -43,6 +43,8 @@ public class SpanSetTagInterceptor implements InstanceMethodsAroundInterceptor { activeSpan.setComponent(tagValue); } else if (Tags.PEER_SERVICE.getKey().equals(tagKey)) { activeSpan.setOperationName(tagValue); + } else if (Tags.ERROR.getKey().equals(tagKey) && "true".equals(tagValue)) { + activeSpan.errorOccurred(); } else { activeSpan.tag(tagKey, tagValue); }