kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: event handler memory leak, buffer never be cleared

This commit is contained in:
wusheng 2016-11-25 09:28:25 +08:00
parent e750b540cc
commit b5e00fe202
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
skywalking-storage-center/skywalking-storage/src/main/java/com/a/eye/skywalking/storage/disruptor/ack/StoreAckSpanEventHandler.java
View File

@ -35,11 +35,15 @@ public class StoreAckSpanEventHandler implements EventHandler<AckSpanData> {
buffer.add(event);
if (endOfBatch || buffer.size() == bufferSize) {
IndexMetaCollection collection = fileWriter.write(buffer);
try {
IndexMetaCollection collection = fileWriter.write(buffer);
operator.batchUpdate(collection);
operator.batchUpdate(collection);
HealthCollector.getCurrentHeathReading("StoreAckSpanEventHandler").updateData(HeathReading.INFO, "%s messages were successful consumed .", buffer.size());
HealthCollector.getCurrentHeathReading("StoreAckSpanEventHandler").updateData(HeathReading.INFO, "%s messages were successful consumed .", buffer.size());
} finally {
buffer.clear();
}
}
}
}

10
skywalking-storage-center/skywalking-storage/src/main/java/com/a/eye/skywalking/storage/disruptor/request/StoreRequestSpanEventHandler.java
View File

@ -35,11 +35,15 @@ public class StoreRequestSpanEventHandler implements EventHandler<RequestSpanDat
buffer.add(event);
if (endOfBatch || buffer.size() == bufferSize) {
IndexMetaCollection collection = fileWriter.write(buffer);
try {
IndexMetaCollection collection = fileWriter.write(buffer);
operator.batchUpdate(collection);
operator.batchUpdate(collection);
HealthCollector.getCurrentHeathReading("StoreRequestSpanEventHandler").updateData(HeathReading.INFO, "%s messages were successful consumed .", buffer.size());
HealthCollector.getCurrentHeathReading("StoreRequestSpanEventHandler").updateData(HeathReading.INFO, "%s messages were successful consumed .", buffer.size());
} finally {
buffer.clear();
}
}
}
}