From a6828e7da27c1e36d377eb2bb1c7379b2b0d7e8c Mon Sep 17 00:00:00 2001 From: Zhenxu Ke Date: Thu, 13 May 2021 09:26:28 +0800 Subject: [PATCH] Fix some dead links (#6934) --- .github/workflows/e2e.storages.yaml | 2 +- docs/en/setup/envoy/metrics_service_setting.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.storages.yaml b/.github/workflows/e2e.storages.yaml index ba3a79843..13f6afd00 100644 --- a/.github/workflows/e2e.storages.yaml +++ b/.github/workflows/e2e.storages.yaml @@ -50,7 +50,7 @@ jobs: ${{ runner.os }}-maven- - name: Build OpenSearch - if: matrix.storage == 'opensearch' + if: env.SKIP_CI != 'true' && matrix.storage == 'opensearch' run: bash test/e2e/e2e-test/docker/build-opensearch.sh - name: Run E2E Test diff --git a/docs/en/setup/envoy/metrics_service_setting.md b/docs/en/setup/envoy/metrics_service_setting.md index 8750de984..dcc48f706 100644 --- a/docs/en/setup/envoy/metrics_service_setting.md +++ b/docs/en/setup/envoy/metrics_service_setting.md @@ -50,7 +50,7 @@ static_resources: A more complete static configuration, can be observed [here](config.yaml). -Note that Envoy can also be configured dynamically through [xDS Protocol](https://github.com/envoyproxy/data-plane-api/blob/main/xds_protocol.rst). +Note that Envoy can also be configured dynamically through [xDS Protocol](https://github.com/envoyproxy/envoy/blob/v1.18.2/api/xds_protocol.rst). As mentioned above, SkyWalking also builds the topology of services from the metrics, this is because Envoy also carries the service metadata along with the metrics, to feed the Envoy such metadata, another configuration part is as follows: @@ -65,7 +65,7 @@ node: ## Configure Envoy to send metrics to SkyWalking with Istio -Typically, Envoy can be also used under Istio's control, where the configurations are much more simple because Istio composes the configurations for you and sends them to Envoy via [xDS Protocol](https://github.com/envoyproxy/data-plane-api/blob/master/xds_protocol.rst). +Typically, Envoy can be also used under Istio's control, where the configurations are much more simple because Istio composes the configurations for you and sends them to Envoy via [xDS Protocol](https://github.com/envoyproxy/envoy/blob/v1.18.2/api/xds_protocol.rst). Istio also automatically injects the metadata such as service name and instance name into the bootstrap configurations. Under this circumstance, emitting the metrics to SyWalking is as simple as adding the option `--set meshConfig.defaultConfig.envoyMetricsService.address=` to Istio install command, for example: