kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix the bug that httpasyncclient-4.x-plugin puts the dirty tracing context in the connection context (#86)

This commit is contained in:
Ze 2021-12-21 11:16:26 +08:00 committed by GitHub
parent 61e0e6de7b
commit 96ea77cf8f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES.md
View File

@ -17,6 +17,7 @@ Release Notes.
* Add dubbo 3.x plugin.
* Fix TracePathMatcher should match pattern "**" with paths end by "/"
* Add support `returnedObj` expression for apm-customize-enhance-plugin
* Fix the bug that httpasyncclient-4.x-plugin puts the dirty tracing context in the connection context
#### Documentation

2
apm-sniffer/apm-sdk-plugin/httpasyncclient-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpasyncclient/v4/LeaseRequestCompletedInterceptor.java
View File

@ -33,7 +33,7 @@ public class LeaseRequestCompletedInterceptor implements InstanceMethodsAroundIn
MethodInterceptResult result) throws Throwable {
PoolEntry entry = (PoolEntry) allArguments[0];
NHttpConnection conn = (NHttpConnection) entry.getConnection();
if (ContextManager.isActive()) {
if (ContextManager.isActive() && !ContextManager.activeSpan().isExit()) {
conn.getContext().setAttribute(Constants.SKYWALKING_CONTEXT_SNAPSHOT, ContextManager.capture());
conn.getContext().setAttribute(Constants.SKYWALKING_HTTP_CONTEXT, Constants.HTTP_CONTEXT_LOCAL.get());
}