kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Envoy heartbeat update bug (#2334)

This commit is contained in:
吴晟 Wu Sheng 2019-03-08 17:41:26 +08:00 committed by GitHub
parent c2a7e8e539
commit 93347b2340
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/MetricServiceGRPCHandler.java
View File

@ -96,6 +96,7 @@ public class MetricServiceGRPCHandler extends MetricsServiceGrpc.MetricsServiceI
if (serviceInstanceId != Const.NONE) {
List<Metrics.MetricFamily> list = message.getEnvoyMetricsList();
boolean needHeartbeatUpdate = true;
for (int i = 0; i < list.size(); i++) {
counter.inc();
HistogramMetric.Timer timer = histogram.createTimer();
@ -123,10 +124,11 @@ public class MetricServiceGRPCHandler extends MetricsServiceGrpc.MetricsServiceI
default:
continue;
}
if (i == 0) {
if (needHeartbeatUpdate) {
// Send heartbeat
serviceInventoryRegister.heartbeat(serviceId, timestamp);
serviceInstanceInventoryRegister.heartbeat(serviceInstanceId, timestamp);
needHeartbeatUpdate = false;
}
} finally {
timer.finish();