kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add test cases for skywalking-logging-impl-log4j2 module(not used right now).

This commit is contained in:
wusheng 2017-02-28 10:21:56 +08:00
parent da1427bf2d
commit 792cf9d1e7
7 changed files with 65 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
skywalking-commons/skywalking-logging/skywalking-logging-api/src/main/java/com/a/eye/skywalking/api/logging/api/ILog.java
View File

@ -14,12 +14,8 @@ public interface ILog {
void warn(String format, Object... arguments);
void warn(String format, Object arguments, Throwable e);
void error(String format, Throwable e);
void error(String format, Object arguments, Throwable e);
boolean isDebugEnable();
boolean isInfoEnable();

9
skywalking-commons/skywalking-logging/skywalking-logging-api/src/main/java/com/a/eye/skywalking/api/logging/api/NoopLogger.java
View File

@ -25,20 +25,11 @@ public enum NoopLogger implements ILog {
}
@Override
public void warn(String format, Object arguments, Throwable e) {
}
@Override
public void error(String format, Throwable e) {
}
@Override
public void error(String format, Object argument, Throwable e) {
}
@Override
public boolean isDebugEnable() {
return false;

8
skywalking-commons/skywalking-logging/skywalking-logging-api/src/test/java/com/a/eye/skywalking/api/logging/api/LogManagerTest.java
View File

@ -50,18 +50,10 @@ public class LogManagerTest {
}
@Override public void warn(String format, Object arguments, Throwable e) {
}
@Override public void error(String format, Throwable e) {
}
@Override public void error(String format, Object arguments, Throwable e) {
}
@Override public boolean isDebugEnable() {
return false;
}

1
skywalking-commons/skywalking-logging/skywalking-logging-api/src/test/java/com/a/eye/skywalking/api/logging/api/NoopLoggerTest.java
View File

@ -24,6 +24,5 @@ public class NoopLoggerTest {
INSTANCE.warn("Any string", new Object[0], new NullPointerException());
INSTANCE.error("Any string");
INSTANCE.error("Any string", new NullPointerException());
INSTANCE.error("Any string", new Object[0], new NullPointerException());
}
}

10
skywalking-commons/skywalking-logging/skywalking-logging-impl-log4j2/src/main/java/com/a/eye/skywalking/api/logging/impl/log4j2/Log4j2Logger.java
View File

@ -28,21 +28,11 @@ public class Log4j2Logger implements ILog {
logger.warn(format, arguments);
}
@Override
public void warn(String format, Object arguments, Throwable e) {
logger.warn(format, arguments, e);
}
@Override
public void error(String message, Throwable e) {
logger.error(message, e);
}
@Override
public void error(String message, Object argument, Throwable e) {
logger.error(message, argument, e);
}
@Override
public boolean isDebugEnable() {
return logger.isDebugEnabled();

47
skywalking-commons/skywalking-logging/skywalking-logging-impl-log4j2/src/test/java/com/a/eye/skywalking/api/logging/impl/log4j2/Log4j2LoggerTest.java Normal file
View File

@ -0,0 +1,47 @@
package com.a.eye.skywalking.api.logging.impl.log4j2;
import org.apache.logging.log4j.Logger;
import org.junit.Test;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
/**
* Created by wusheng on 2017/2/28.
*/
public class Log4j2LoggerTest {
@Test
public void testLogProxy(){
Logger mockLogger = spy(Logger.class);
Log4j2Logger logger = new Log4j2Logger(mockLogger);
logger.isDebugEnable();
verify(mockLogger, times(1)).isDebugEnabled();
logger.isInfoEnable();
verify(mockLogger, times(1)).isInfoEnabled();
logger.isWarnEnable();
verify(mockLogger, times(1)).isWarnEnabled();
logger.isErrorEnable();
verify(mockLogger, times(1)).isErrorEnabled();
logger.debug("string");
verify(mockLogger, times(1)).debug("string");
logger.debug("string", "arg1", "args");
verify(mockLogger, times(1)).debug("string", new Object[]{"arg1", "args"});
logger.info("string");
verify(mockLogger, times(1)).info("string");
logger.info("string", "arg1", "args");
verify(mockLogger, times(1)).info("string", new Object[]{"arg1", "args"});
logger.warn("string", "arg1", "args");
verify(mockLogger, times(1)).warn("string", new Object[]{"arg1", "args"});
logger.error("string");
verify(mockLogger, times(1)).error("string");
NullPointerException exception = new NullPointerException();
logger.error("string", exception);
verify(mockLogger, times(1)).error("string", exception);
}
}

18
skywalking-commons/skywalking-logging/skywalking-logging-impl-log4j2/src/test/java/com/a/eye/skywalking/api/logging/impl/log4j2/Log4j2ResolverTest.java Normal file
View File

@ -0,0 +1,18 @@
package com.a.eye.skywalking.api.logging.impl.log4j2;
import com.a.eye.skywalking.api.logging.api.ILog;
import org.junit.Assert;
import org.junit.Test;
/**
* Created by wusheng on 2017/2/28.
*/
public class Log4j2ResolverTest {
@Test
public void testGetLogger() {
Log4j2Resolver resolver = new Log4j2Resolver();
ILog logger = resolver.getLogger(Log4j2ResolverTest.class);
Assert.assertTrue(logger instanceof Log4j2Logger);
}
}