kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update committer review and merge guide (#4383)

This commit is contained in:
kezhenxu94 2020-02-19 21:10:26 +08:00 committed by GitHub
parent 8ff8cd0565
commit 78d38d6782
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/en/guides/asf/committer.md
View File

@ -121,11 +121,11 @@ Notice, if never got your GitHub invitation? Visit github.com/apache to see if y
If you want others could see you are in the Apache GitHub org, you need to go to [Apache GitHub org people page](https://github.com/orgs/apache/people),
search for yourself, and choose `Organization visibility` to `Public`.
### Committer right, duty and responsibility
### Committer rights, duties and responsibilities
SkyWalking project doesn't require the continue contributions after you become a committer, but we hope and truly want you could.
Being a committer, you could
1. Review and merge the pull request to the master branch in the Apache repo. For new committer, we hope you could request some senior committer to recheck the pull request.
1. Review and merge the pull request to the master branch in the Apache repo. A pull request often contains multiple commits. Those commits **must be squashed and merged** into a single commit **with explanatory comments**. For new committer, we hope you could request some senior committer to recheck the pull request.
1. Create and push codes to new branch in the Apache repo.
1. Follow the [Release process](../How-to-release.md) to process new release. Of course, you need to ask committer team
to confirm it is the right time to release.