kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Print exception stack into console or log files because of I found some NPE message in the log files. But I don't known where are they from without exception stack. (#1986)

This commit is contained in:
彭勇升 pengys 2018-12-01 00:09:39 +08:00 committed by GitHub
parent e2f2356a6f
commit 5777103a2b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 21 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/cache/NetworkAddressInventoryCacheEsDAO.java vendored
View File

@ -19,7 +19,7 @@
package org.apache.skywalking.oap.server.storage.plugin.elasticsearch.cache;
import org.apache.skywalking.oap.server.core.Const;
import org.apache.skywalking.oap.server.core.register.*;
import org.apache.skywalking.oap.server.core.register.NetworkAddressInventory;
import org.apache.skywalking.oap.server.core.storage.cache.INetworkAddressInventoryCacheDAO;
import org.apache.skywalking.oap.server.library.client.elasticsearch.ElasticSearchClient;
import org.apache.skywalking.oap.server.storage.plugin.elasticsearch.base.EsDAO;
@ -52,8 +52,8 @@ public class NetworkAddressInventoryCacheEsDAO extends EsDAO implements INetwork
} else {
return Const.NONE;
}
} catch (Throwable e) {
logger.error(e.getMessage());
} catch (Throwable t) {
logger.error(t.getMessage(), t);
return Const.NONE;
}
}
@ -71,8 +71,8 @@ public class NetworkAddressInventoryCacheEsDAO extends EsDAO implements INetwork
} else {
return null;
}
} catch (Throwable e) {
logger.error(e.getMessage());
} catch (Throwable t) {
logger.error(t.getMessage(), t);
return null;
}
}

8
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/cache/ServiceInstanceInventoryCacheDAO.java vendored
View File

@ -56,8 +56,8 @@ public class ServiceInstanceInventoryCacheDAO extends EsDAO implements IServiceI
} else {
return null;
}
} catch (Throwable e) {
logger.error(e.getMessage());
} catch (Throwable t) {
logger.error(t.getMessage(), t);
return null;
}
}
@ -80,8 +80,8 @@ public class ServiceInstanceInventoryCacheDAO extends EsDAO implements IServiceI
} else {
return Const.NONE;
}
} catch (Throwable e) {
logger.error(e.getMessage());
} catch (Throwable t) {
logger.error(t.getMessage(), t);
return Const.NONE;
}
}

12
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/cache/ServiceInventoryCacheEsDAO.java vendored
View File

@ -63,8 +63,8 @@ public class ServiceInventoryCacheEsDAO extends EsDAO implements IServiceInvento
} else {
return Const.NONE;
}
} catch (Throwable e) {
logger.error(e.getMessage());
} catch (Throwable t) {
logger.error(t.getMessage(), t);
return Const.NONE;
}
}
@ -82,8 +82,8 @@ public class ServiceInventoryCacheEsDAO extends EsDAO implements IServiceInvento
} else {
return null;
}
} catch (Throwable e) {
logger.error(e.getMessage());
} catch (Throwable t) {
logger.error(t.getMessage(), t);
return null;
}
}
@ -106,8 +106,8 @@ public class ServiceInventoryCacheEsDAO extends EsDAO implements IServiceInvento
for (SearchHit searchHit : response.getHits().getHits()) {
serviceInventories.add(this.builder.map2Data(searchHit.getSourceAsMap()));
}
} catch (Throwable e) {
logger.error(e.getMessage());
} catch (Throwable t) {
logger.error(t.getMessage(), t);
}
return serviceInventories;

2
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/lock/RegisterLockDAOImpl.java
View File

@ -89,7 +89,7 @@ public class RegisterLockDAOImpl extends EsDAO implements IRegisterLockDAO {
getClient().forceUpdate(RegisterLockIndex.NAME, id, source);
} catch (Throwable t) {
logger.error("Release lock failure.");
logger.error("Release lock failure.", t);
}
}
}

14
oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2ServiceInventoryCacheDAO.java
View File

@ -19,17 +19,13 @@
package org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao;
import java.io.IOException;
import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.List;
import java.sql.*;
import java.util.*;
import org.apache.skywalking.oap.server.core.register.ServiceInventory;
import org.apache.skywalking.oap.server.core.storage.cache.IServiceInventoryCacheDAO;
import org.apache.skywalking.oap.server.library.client.jdbc.hikaricp.JDBCHikariCPClient;
import org.apache.skywalking.oap.server.library.util.BooleanUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.slf4j.*;
/**
* @author wusheng
@ -82,8 +78,8 @@ public class H2ServiceInventoryCacheDAO extends H2SQLExecutor implements IServic
} catch (SQLException e) {
throw new IOException(e);
}
} catch (Throwable e) {
logger.error(e.getMessage());
} catch (Throwable t) {
logger.error(t.getMessage(), t);
}
return serviceInventories;
}