kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix tag.get NullPointException

This commit is contained in:
wusheng 2017-03-03 16:24:31 +08:00
parent de6e680615
commit 507b6b06f3
3 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
skywalking-commons/skywalking-trace/src/main/java/com/a/eye/skywalking/trace/tag/BooleanTag.java
View File

@ -7,7 +7,7 @@ import com.a.eye.skywalking.trace.Span;
*
* Created by wusheng on 2017/2/17.
*/
public class BooleanTag extends AbstractTag<Boolean>{
public class BooleanTag extends AbstractTag<Boolean> {
public BooleanTag(String key) {
super(key);
}
@ -18,8 +18,8 @@ public class BooleanTag extends AbstractTag<Boolean>{
}
/**
* Get a tag value, type of {@link Boolean}.
* After akka-message/serialize, all tags values are type of {@link String}, convert to {@link Boolean}, if necessary.
* Get a tag value, type of {@link Boolean}. After akka-message/serialize, all tags values are type of {@link
* String}, convert to {@link Boolean}, if necessary.
*
* @param span
* @return tag value
@ -27,9 +27,11 @@ public class BooleanTag extends AbstractTag<Boolean>{
@Override
public Boolean get(Span span) {
Object tagValue = span.getTag(super.key);
if(tagValue instanceof Boolean){
if (tagValue == null) {
return null;
} else if (tagValue instanceof Boolean) {
return (Boolean)tagValue;
}else {
} else {
return Boolean.valueOf(tagValue.toString());
}
}

4
skywalking-commons/skywalking-trace/src/main/java/com/a/eye/skywalking/trace/tag/IntTag.java
View File

@ -27,7 +27,9 @@ public class IntTag extends AbstractTag<Integer> {
@Override
public Integer get(Span span) {
Object tagValue = span.getTag(super.key);
if(tagValue instanceof Integer){
if (tagValue == null) {
return null;
} else if(tagValue instanceof Integer){
return (Integer)tagValue;
}else {
return Integer.valueOf(tagValue.toString());

4
skywalking-commons/skywalking-trace/src/main/java/com/a/eye/skywalking/trace/tag/ShortTag.java
View File

@ -26,7 +26,9 @@ public class ShortTag extends AbstractTag<Short> {
*/
@Override public Short get(Span span) {
Object tagValue = span.getTag(super.key);
if(tagValue instanceof Short){
if (tagValue == null) {
return null;
} else if(tagValue instanceof Short){
return (Short)tagValue;
}else {
return Short.valueOf(tagValue.toString());