kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix ALS K8SServiceRegistry didn't remove the correct entry (#6658) 

* Fix ALS K8SServiceRegistry didn't remove the correct entry

* Add changes

Co-authored-by: Zhenxu Ke <kezhenxu94@apache.org>
This commit is contained in:
wankai123 2021-04-01 06:14:01 +08:00 committed by GitHub
parent 7d06c210ae
commit 4af2b61027
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES.md
View File

@ -63,6 +63,7 @@ Release Notes.
* Optimize the self monitoring grafana dashboard.
* Enhance the export service.
* Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
* Fix ALS K8SServiceRegistry didn't remove the correct entry.
* Using "service.istio.io/canonical-name" to replace "app" label to resolve Envoy ALS service name
#### UI

2
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/k8s/K8SServiceRegistry.java
View File

@ -209,7 +209,7 @@ public class K8SServiceRegistry {
protected void removeService(final V1Service service) {
ofNullable(service.getMetadata()).ifPresent(
metadata -> idServiceMap.remove(metadata.getUid())
metadata -> idServiceMap.remove(metadata.getNamespace() + ":" + metadata.getName())
);
}