From 4a0a210348a1c44663df9773765614d05205688c Mon Sep 17 00:00:00 2001 From: lytscu Date: Mon, 15 Jan 2018 19:19:49 +0800 Subject: [PATCH] Modify ComponentsDefine.java --- .../apm/network/trace/component/ComponentsDefine.java | 2 -- .../httpasyncclient/v4/ProcessResponseInterceptor.java | 8 +++++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java b/apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java index ceae7ca99..b23f30cf3 100644 --- a/apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java +++ b/apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java @@ -78,8 +78,6 @@ public class ComponentsDefine { public static final OfficialComponent HTTP_ASYNC_CLIENT = new OfficialComponent(26, "httpasyncclient"); - - private static ComponentsDefine INSTANCE = new ComponentsDefine(); private String[] components; diff --git a/apm-sniffer/apm-sdk-plugin/httpasyncclient-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpasyncclient/v4/ProcessResponseInterceptor.java b/apm-sniffer/apm-sdk-plugin/httpasyncclient-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpasyncclient/v4/ProcessResponseInterceptor.java index 8cb93565d..1cfc1db3a 100644 --- a/apm-sniffer/apm-sdk-plugin/httpasyncclient-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpasyncclient/v4/ProcessResponseInterceptor.java +++ b/apm-sniffer/apm-sdk-plugin/httpasyncclient-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpasyncclient/v4/ProcessResponseInterceptor.java @@ -28,7 +28,9 @@ import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInt import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; /** - * End exit span and create a local span of future/Callback. + * 1.End exit span. + * 2.Create a local span of callback. + * 3.End local span:AsyncThread/execute. * * @author liyuntao */ @@ -47,9 +49,9 @@ public class ProcessResponseInterceptor implements InstanceMethodsAroundIntercep @Override public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class[] argumentsTypes, Object ret) throws Throwable { - //stop local span:future/Callback + //stop local span:callback ContextManager.stopSpan(); - //stop local span:httpasyncclient/request + //stop local span:AsyncThread/execute ContextManager.stopSpan(); return ret;