Use client side component name when no server side mapping. (#5232)

* Use client side component name when no server side mapping.

* Unknown component should be fixed, so change the e2e expected data.
This commit is contained in:
吴晟 Wu Sheng 2020-08-05 13:34:58 +08:00 committed by GitHub
parent 4149ac59fe
commit 48311e095a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 9 deletions

View File

@ -22,7 +22,6 @@ import java.io.FileNotFoundException;
import java.io.Reader;
import java.util.HashMap;
import java.util.Map;
import org.apache.skywalking.oap.server.core.Const;
import org.apache.skywalking.oap.server.library.util.ResourceUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@ -65,7 +64,7 @@ public class ComponentLibraryCatalogService implements IComponentLibraryCatalogS
@Override
public String getServerNameBasedOnComponent(int componentId) {
Integer serverComponentId = componentId2ServerId.get(componentId);
return serverComponentId == null ? Const.UNKNOWN : getComponentName(serverComponentId);
return serverComponentId == null ? getComponentName(componentId) : getComponentName(serverComponentId);
}
private void init() throws InitialComponentCatalogException {
@ -96,10 +95,12 @@ public class ComponentLibraryCatalogService implements IComponentLibraryCatalogS
nameMapping.forEach((name, serverName) -> {
if (!componentName2Id.containsKey(name)) {
throw new InitialComponentCatalogException("Component name [" + name + "] in Component-Server-Mappings doesn't exist in component define. ");
throw new InitialComponentCatalogException(
"Component name [" + name + "] in Component-Server-Mappings doesn't exist in component define. ");
}
if (!componentName2Id.containsKey(serverName)) {
throw new InitialComponentCatalogException("Server componentId name [" + serverName + "] in Component-Server-Mappings doesn't exist in component define. ");
throw new InitialComponentCatalogException(
"Server componentId name [" + serverName + "] in Component-Server-Mappings doesn't exist in component define. ");
}
componentId2ServerId.put(componentName2Id.get(name), componentName2Id.get(serverName));

View File

@ -24,13 +24,13 @@ nodes:
name: not null
serviceId: not null
serviceName: e2e-service-provider
type: Unknown
type: not null
isReal: true
- id: not null
name: not null
serviceId: not null
serviceName: e2e-service-provider
type: Unknown
type: not null
isReal: true
calls:
- id: not null

View File

@ -24,13 +24,13 @@ nodes:
name: not null
serviceId: not null
serviceName: e2e-service-provider
type: Unknown
type: not null
isReal: true
- id: not null
name: not null
serviceId: not null
serviceName: e2e-service-provider
type: Unknown
type: not null
isReal: true
calls:
- id: not null

View File

@ -28,7 +28,7 @@ nodes:
type: H2
- id: not null
name: "gateway:80"
type: Unknown
type: not null
calls:
- id: not null
source: ${User[0]}