From 450a7ec4e02f7e5a6b2e8f474dbf71c589effc6a Mon Sep 17 00:00:00 2001 From: zifeihan Date: Mon, 24 Aug 2020 15:01:59 +0800 Subject: [PATCH] change alarm module silence-period default value as same as period. (#5372) Co-authored-by: echo --- .../skywalking/oap/server/core/alarm/provider/RulesReader.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java index 9f5f9478c..e0909dea7 100644 --- a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java +++ b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java @@ -76,7 +76,8 @@ public class RulesReader { alarmRule.setOp((String) settings.get("op")); alarmRule.setPeriod((Integer) settings.getOrDefault("period", 1)); alarmRule.setCount((Integer) settings.getOrDefault("count", 1)); - alarmRule.setSilencePeriod((Integer) settings.getOrDefault("silence-period", -1)); + // How many times of checks, the alarm keeps silence after alarm triggered, default as same as period. + alarmRule.setSilencePeriod((Integer) settings.getOrDefault("silence-period", alarmRule.getPeriod())); alarmRule.setMessage( (String) settings.getOrDefault("message", "Alarm caused by Rule " + alarmRule .getAlarmRuleName()));