kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Optimize code (#3600)

This commit is contained in:
echooymxq 2019-10-11 19:17:03 +08:00 committed by Jared Tan
parent a848033a75
commit 1b1e80b75a
6 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/AgentIDDecorator.java
View File

@ -57,7 +57,7 @@ public class AgentIDDecorator implements ChannelDecorator {
Attributes mainAttribs = manifest.getMainAttributes();
String projectName = mainAttribs.getValue("Implementation-Vendor-Id");
if (projectName != null) {
if (projectName.equals("org.apache.skywalking")) {
if ("org.apache.skywalking".equals(projectName)) {
version = mainAttribs.getValue("Implementation-Version");
}
}

2
apm-sniffer/apm-sdk-plugin/spring-plugins/core-patch/src/main/java/org/apache/skywalking/apm/plugin/spring/patch/GetPropertyDescriptorsInterceptor.java
View File

@ -44,7 +44,7 @@ public class GetPropertyDescriptorsInterceptor implements InstanceMethodsAroundI
if (EnhancedInstance.class.isAssignableFrom(((BeanWrapperImpl)objInst).getRootClass())) {
List<PropertyDescriptor> newPropertyDescriptors = new ArrayList<PropertyDescriptor>();
for (PropertyDescriptor descriptor : propertyDescriptors) {
if (!descriptor.getName().equals("skyWalkingDynamicField")) {
if (!"skyWalkingDynamicField".equals(descriptor.getName())) {
newPropertyDescriptors.add(descriptor);
}
}

4
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/RunningMode.java
View File

@ -43,7 +43,7 @@ public class RunningMode {
* @return true if in this status
*/
public static boolean isInitMode() {
return MODE.equals("init");
return "init".equals(MODE);
}
/**
@ -51,6 +51,6 @@ public class RunningMode {
* @return true if in this status.
*/
public static boolean isNoInitMode() {
return MODE.equals("no-init");
return "no-init".equals(MODE);
}
}

2
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/data/LimitedSizeDataCollection.java
View File

@ -35,7 +35,7 @@ public class LimitedSizeDataCollection<STORAGE_DATA extends ComparableStorageDat
this.limitedSize = limitedSize;
}
public void finishWriting() {
@Override public void finishWriting() {
writing = false;
}

2
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/data/MergeDataCollection.java
View File

@ -36,7 +36,7 @@ public class MergeDataCollection<STREAM_DATA extends StreamData> implements SWCo
this.reading = false;
}
public void finishWriting() {
@Override public void finishWriting() {
writing = false;
}

2
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/data/NonMergeDataCollection.java
View File

@ -36,7 +36,7 @@ public class NonMergeDataCollection<STORAGE_DATA extends StorageData> implements
this.reading = false;
}
public void finishWriting() {
@Override public void finishWriting() {
writing = false;
}