kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

improve AsyncSpan API: make #asyncFinish and #prepareForAsync can not invoke more than once (#3201) 

* improve AsyncSpan API: make #asyncFinish and #prepareForAsync can not invoke more than once
make the API more strong: make the plugin code bug fail-fast
This commit is contained in:
qxo 2019-08-06 08:30:29 +08:00 committed by 吴晟 Wu Sheng
parent c139316bbe
commit 1ae04cf2bb
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractTracingSpan.java
View File

@ -40,7 +40,14 @@ public abstract class AbstractTracingSpan implements AbstractSpan {
protected String operationName;
protected int operationId;
protected SpanLayer layer;
protected boolean isInAsyncMode = false;
/**
* The span has been tagged in async mode, required async stop to finish.
*/
protected volatile boolean isInAsyncMode = false;
/**
* The flag represents whether the span has been async stopped
*/
private volatile boolean isAsyncStopped = false;
protected volatile AbstractTracerContext context;
/**
@ -322,6 +329,9 @@ public abstract class AbstractTracingSpan implements AbstractSpan {
}
@Override public AbstractSpan prepareForAsync() {
if (isInAsyncMode) {
throw new RuntimeException("Prepare for async repeatedly. Span is already in async mode.");
}
context = ContextManager.awaitFinishAsync(this);
isInAsyncMode = true;
return this;
@ -331,9 +341,12 @@ public abstract class AbstractTracingSpan implements AbstractSpan {
if (!isInAsyncMode) {
throw new RuntimeException("Span is not in async mode, please use '#prepareForAsync' to active.");
}
if (isAsyncStopped) {
throw new RuntimeException("Can not do async finish for the span repeately.");
}
this.endTime = System.currentTimeMillis();
context.asyncStop(this);
isAsyncStopped = true;
return this;
}
}