From 16de88c1118e240299bfb9c2fb218d73216edc3d Mon Sep 17 00:00:00 2001 From: mrproliu <741550557@qq.com> Date: Sun, 15 Mar 2020 20:32:36 +0800 Subject: [PATCH] Fix query profiled segments error (#4516) Co-authored-by: Mrproliu --- .../plugin/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java b/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java index 58214e48c..871962ad9 100644 --- a/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java +++ b/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java @@ -79,9 +79,8 @@ public class H2ProfileThreadSnapshotQueryDAO implements IProfileThreadSnapshotQu // search traces sql = new StringBuilder(); sql.append("select * from ").append(SegmentRecord.INDEX_NAME).append(" where "); - sql.append(" 1=1 "); for (int i = 0; i < segments.size(); i++) { - sql.append(" and ").append(SegmentRecord.SEGMENT_ID).append(" = ? "); + sql.append(i > 0 ? " or " : "").append(SegmentRecord.SEGMENT_ID).append(" = ? "); } sql.append(" order by ").append(SegmentRecord.START_TIME).append(" ").append(SortOrder.DESC);