From 05b0498fedcad2b85ec03a36a99625f8900d6db4 Mon Sep 17 00:00:00 2001 From: kezhenxu94 Date: Fri, 15 Mar 2019 14:03:30 +0800 Subject: [PATCH] extract immutable object to reduce garbages (#2364) --- .../skywalking/oap/query/graphql/GraphQLQueryHandler.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/oap-server/server-query-plugin/query-graphql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/GraphQLQueryHandler.java b/oap-server/server-query-plugin/query-graphql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/GraphQLQueryHandler.java index ae805e42a..ad4dcf6d0 100644 --- a/oap-server/server-query-plugin/query-graphql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/GraphQLQueryHandler.java +++ b/oap-server/server-query-plugin/query-graphql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/GraphQLQueryHandler.java @@ -30,6 +30,7 @@ import graphql.GraphQLError; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; +import java.lang.reflect.Type; import java.util.List; import java.util.Map; import javax.servlet.http.HttpServletRequest; @@ -51,6 +52,8 @@ public class GraphQLQueryHandler extends JettyJsonHandler { private static final String MESSAGE = "message"; private final Gson gson = new Gson(); + private final Type mapOfStringObjectType = new TypeToken>() { + }.getType(); private final String path; @@ -75,8 +78,7 @@ public class GraphQLQueryHandler extends JettyJsonHandler { JsonObject requestJson = gson.fromJson(request.toString(), JsonObject.class); - return execute(requestJson.get(QUERY).getAsString(), gson.fromJson(requestJson.get(VARIABLES), new TypeToken>() { - }.getType())); + return execute(requestJson.get(QUERY).getAsString(), gson.fromJson(requestJson.get(VARIABLES), mapOfStringObjectType)); } private JsonObject execute(String request, Map variables) {