From 0146aa522f0c5fe6683e07a4efdd789628102378 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=90=B4=E6=99=9F=20Wu=20Sheng?= Date: Mon, 3 Aug 2020 06:53:00 +0800 Subject: [PATCH] Exporter INCREMENT mode is not working. (#5220) --- .../analysis/worker/MetricsPersistentWorker.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java index ae68a2032..fd1eb6f1a 100644 --- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java +++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java @@ -176,17 +176,17 @@ public class MetricsPersistentWorker extends PersistenceWorker { cachedMetrics.calculate(); prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics)); nextWorker(cachedMetrics); - - /* - * The `data` should be not changed in any case. Exporter is an async process. - */ - nextExportWorker.ifPresent(exportEvenWorker -> exportEvenWorker.in( - new ExportEvent(metrics, ExportEvent.EventType.INCREMENT))); } else { metrics.calculate(); prepareRequests.add(metricsDAO.prepareBatchInsert(model, metrics)); nextWorker(metrics); } + + /* + * The `metrics` should be not changed in all above process. Exporter is an async process. + */ + nextExportWorker.ifPresent(exportEvenWorker -> exportEvenWorker.in( + new ExportEvent(metrics, ExportEvent.EventType.INCREMENT))); } } catch (Throwable t) { log.error(t.getMessage(), t);