kazusa
/
skywalking-java
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Java agent memory leak when enhance `Worker thread` at use Thread Pool (#5009)

This commit is contained in:
于玉桔 2020-07-02 09:27:06 +08:00 committed by GitHub
parent 1817386391
commit 00619a9a3d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
docs/en/FAQ/Memory-leak-enhance-Worker-thread.md Normal file
View File

@ -0,0 +1,32 @@
### Problem
When using a thread pool, `TraceSegment` data in a thread cannot be reported and there are memory data that cannot be recycled (memory leaks)
### Example
``` java
ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor();
executor.setThreadFactory(r -> new Thread(RunnableWrapper.of(r)));
```
### Reason
* Worker threads are enhanced, when using thread pool.
* According to the SkyWalking Java Agent design, when you want to trace cross thread, you need to enhance the task thread.
### Resolve
* When using `Thread Schedule Framework`
Checked SkyWalking Thread Schedule Framework at [SkyWalking Java agent supported list](../setup/service-agent/java-agent/Supported-list.md), such as Spring FrameWork @Async, which can implement tracing without any modification.
* When using `Custom Thread Pool`
Enhance the task thread with the following usage.
```java
ExecutorService executorService = Executors.newFixedThreadPool(1);
executorService.execute(RunnableWrapper.of(new Runnable() {
@Override public void run() {
//your code
}
}));
```
See [across thread solution APIs](../setup/service-agent/java-agent/Application-toolkit-trace-cross-thread.md) for more usage

3
docs/en/FAQ/README.md
View File

@ -24,4 +24,5 @@ These are known and common FAQs. We welcome you to contribute yours.
* [No data shown and backend replies with "Variable 'serviceId' has coerced Null value for NonNull type 'ID!'"](time-and-timezone.md)
* [**Unexpected endpoint register** warning after 6.6.0](Unexpected-endpoint-register.md)
* [Use the profile exporter tool if the profile analysis is not right](../guides/backend-profile-export.md)
* [Compatible with other javaagent bytecode processing](Compatible-with-other-javaagent-bytecode-processing.md)
* [Compatible with other javaagent bytecode processing](Compatible-with-other-javaagent-bytecode-processing.md)
* [**Java agent memory leak** when enhance `Worker thread` at use Thread Pool](Memory-leak-enhance-Worker-thread.md)